Re: [PATCH] Input: synaptic - reverting dcb00fc799dc03fd320e123e4c81b3278c763ea5 because it breaks the touchpad for one guy on Reddit.

From: Hans de Goede <hdegoede@redhat.com>
To: Colton Booth <colton@boothsoftware.ca>, dmitry.torokhov@gmail.com
Cc: colton@boothlinux.ca, Lyude Paul <lyude@redhat.com>,
	Lee Jones <lee.jones@linaro.org>,
	Vincent Huang <vincent.huang@tw.synaptics.com>,
	Dennis Kadioglu <denk@eclipso.email>,
	"Jason A. Donenfeld" <Jason@zx2c4.com>,
	Yussuf Khalil <dev@pp3345.net>, Ilya Katsnelson <me@0upti.me>,
	Gaurav Agrawal <agrawalgaurav@gnome.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: synaptic - reverting dcb00fc799dc03fd320e123e4c81b3278c763ea5 because it breaks the touchpad for one guy on Reddit.
Date: Sun, 7 Feb 2021 11:18:55 +0100	[thread overview]
Message-ID: <08362ef4-c407-9cd0-20fa-354cd8e73fcb@redhat.com> (raw)
In-Reply-To: <20210207035024.69095-1-colton@boothsoftware.ca>

Hi,

On 2/7/21 4:50 AM, Colton Booth wrote:
> I can't test myself since I don't have the correct hardware, BUT this change seems to work for him. I'm thinking he has an early version of the X1E which may use slightly different trackpad revision.

Who is "him"? Do you have a bug-report link or some such ?

With which kernel version is this ?  Could it be that the commit you are reverting was
backported to a stable-series release while that stable series is missing the rmi4
updates necessary to make things work on newer models ?

What are the symptoms / problems "him" is seeing when not reverting this?

On case it is not clear: NACK due to insufficient information why this is
necessary / missing description and root cause analysis of the actual problem.

Regards,

Hans

> 
> Signed-off-by: Colton Booth <colton@boothsoftware.ca>
> ---
>  drivers/input/mouse/synaptics.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
> index ffad142801b3..2d3f03921dbc 100644
> --- a/drivers/input/mouse/synaptics.c
> +++ b/drivers/input/mouse/synaptics.c
> @@ -179,9 +179,7 @@ static const char * const smbus_pnp_ids[] = {
>  	"LEN0093", /* T480 */
>  	"LEN0096", /* X280 */
>  	"LEN0097", /* X280 -> ALPS trackpoint */
> -	"LEN0099", /* X1 Extreme Gen 1 / P1 Gen 1 */
>  	"LEN009b", /* T580 */
> -	"LEN0402", /* X1 Extreme Gen 2 / P1 Gen 2 */
>  	"LEN200f", /* T450s */
>  	"LEN2044", /* L470  */
>  	"LEN2054", /* E480 */
> 