From: Stefan Wahren <wahrenst@gmx.net>
To: Iago Toral Quiroga <itoral@igalia.com>
Cc: Maira Canal <mcanal@igalia.com>,
DRI Development <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 3/3] drm/v3d: add brcm, 2712-v3d as a compatible V3D device
Date: Fri, 29 Sep 2023 07:34:19 +0200 [thread overview]
Message-ID: <083b109c-4418-d613-1135-329a43dfac4b@gmx.net> (raw)
In-Reply-To: <20230928114532.167854-4-itoral@igalia.com>
Hi Iago,
additional to Maria's comments:
Please keep the order of the compatible strings.
Also you need to update the device tree binding before this patch:
Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml
Also make sure that the series is send to the maintainers, not just
dri-devel by using scripts/get_maintainer.pl
Best regards
prev parent reply other threads:[~2023-09-29 7:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-28 11:45 [PATCH 0/3] V3D module changes for Pi5 Iago Toral Quiroga
2023-09-28 11:45 ` [PATCH 1/3] drm/v3d: fix up register addresses for V3D 7.x Iago Toral Quiroga
2023-09-28 15:03 ` Maira Canal
2023-09-29 6:33 ` itoral
2023-09-28 11:45 ` [PATCH 2/3] drm/v3d: update UAPI to match user-space " Iago Toral Quiroga
2023-09-28 15:05 ` Maira Canal
2023-09-29 6:30 ` itoral
2023-09-28 11:45 ` [PATCH 3/3] drm/v3d: add brcm,2712-v3d as a compatible V3D device Iago Toral Quiroga
2023-09-28 15:06 ` [PATCH 3/3] drm/v3d: add brcm, 2712-v3d " Maira Canal
2023-09-29 5:34 ` Stefan Wahren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=083b109c-4418-d613-1135-329a43dfac4b@gmx.net \
--to=wahrenst@gmx.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=itoral@igalia.com \
--cc=mcanal@igalia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.