Re: [PATCH] exit if we fail to initialize kvm

From: Alexander Graf <agraf@suse.de>
To: Glauber Costa <glommer@redhat.com>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"avi@redhat.com" <avi@redhat.com>
Subject: Re: [PATCH] exit if we fail to initialize kvm
Date: Tue, 28 Jul 2009 23:38:21 +0200	[thread overview]
Message-ID: <0872EC88-DDBB-46BC-B2C0-81363417A71C@suse.de> (raw)
In-Reply-To: <20090728212852.GY4776@poweredge.glommer>

On 28.07.2009, at 23:28, Glauber Costa <glommer@redhat.com> wrote:

> On Tue, Jul 28, 2009 at 11:15:19PM +0200, Alexander Graf wrote:
>>
>> On 28.07.2009, at 22:52, Glauber Costa <glommer@redhat.com> wrote:
>>
>>> Falling back to tcg has proven to be evil through time. The option  
>>> is
>>> to
>>> do not try to act behind user's back, and quit the program  
>>> completely
>>> if
>>> we fail to initialize kvm. Right now, the only way to run tcg from  
>>> our
>>> tree
>>> becomes explicitly asking for it, with the -no-kvm option.
>>
>> Well, actually there's one little difference: I tell the user to  
>> use -
>> no-kvm if he really wants cpu emulation.
>>
>> But simply failing is probably good enough.
> With my patch, we won't fail if the user asked -no-kvm, because then  
> we won't
> even try to initialize kvm.
>
> We only exit here, if we try, but fail
>

Right, the difference is that instead of saying "initializing kvm  
failed" it would give the user some advice on what happened and what  
to do next.

Alex