From: Bart Van Assche <bvanassche@acm.org>
To: Yu Kuai <yukuai1@huaweicloud.com>, Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, Jan Kara <jack@suse.cz>,
Paolo Valente <paolo.valente@linaro.org>,
"yukuai (C)" <yukuai3@huawei.com>
Subject: Re: [PATCH] block: BFQ: Add several invariant checks
Date: Wed, 17 May 2023 07:24:32 -0700 [thread overview]
Message-ID: <090f0916-6bb0-8b65-b4f3-fef0ef649069@acm.org> (raw)
In-Reply-To: <47edc92d-129d-10d2-8a2e-9870d8748be4@huaweicloud.com>
On 5/16/23 18:26, Yu Kuai wrote:
> 在 2023/05/17 6:38, Bart Van Assche 写道:
>> If anything goes wrong with the counters that track the number of
>> requests, I/O locks up. Make such scenarios easier to debug by adding
>> invariant checks for the request counters. Additionally, check that
>> BFQ queues are empty before these are freed.
>
> Is there any real problems related to those counters?
No, but I encountered an I/O lockup in BFQ while modifying the block
layer core. This code was helpful while analyzing the lockup. All that
is needed to reproduce the lockup is to call bfq_dispatch_request() and
bfq_insert_requests() without calling bfq_finish_requeue_request()
between these two calls.
Bart.
next prev parent reply other threads:[~2023-05-17 14:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-16 22:38 [PATCH] block: BFQ: Add several invariant checks Bart Van Assche
2023-05-17 1:26 ` Yu Kuai
2023-05-17 14:24 ` Bart Van Assche [this message]
2023-05-19 2:20 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=090f0916-6bb0-8b65-b4f3-fef0ef649069@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=paolo.valente@linaro.org \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.