From: Sergey Shtylyov <s.shtylyov@omp.ru>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
<netdev@vger.kernel.org>
Cc: <linux-renesas-soc@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v2] Revert "sh_eth: remove open coded netif_running()"
Date: Mon, 27 Mar 2023 21:06:39 +0300 [thread overview]
Message-ID: <09108926-4d0c-79b7-5e8b-36deff4561e5@omp.ru> (raw)
In-Reply-To: <20230327152112.15635-1-wsa+renesas@sang-engineering.com>
On 3/27/23 6:21 PM, Wolfram Sang wrote:
> This reverts commit ce1fdb065695f49ef6f126d35c1abbfe645d62d5. It turned
> out this actually introduces a race condition. netif_running() is not a
> suitable check for get_stats.
>
> Reported-by: Sergey Shtylyov <s.shtylyov@omp.ru>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
[...]
Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
MBR, Sergey
next prev parent reply other threads:[~2023-03-27 18:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 15:21 [PATCH net-next v2] Revert "sh_eth: remove open coded netif_running()" Wolfram Sang
2023-03-27 18:06 ` Sergey Shtylyov [this message]
2023-03-28 15:03 ` Simon Horman
2023-03-29 2:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09108926-4d0c-79b7-5e8b-36deff4561e5@omp.ru \
--to=s.shtylyov@omp.ru \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.