From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: puranjay12@gmail.com, jic23@kernel.org, lars@metafoo.de,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH] dt-bindings: iio: ti,tmp117: add optional label binding
Date: Mon, 26 Feb 2024 13:42:20 +0100 [thread overview]
Message-ID: <09f4b87e-8344-4051-aa69-5117f6c5e481@linaro.org> (raw)
In-Reply-To: <20240226102323.6awrkxrdfq7j3ymj@pengutronix.de>
On 26/02/2024 11:23, Marco Felsch wrote:
> On 24-02-26, Krzysztof Kozlowski wrote:
>> On 23/02/2024 17:20, Marco Felsch wrote:
>>> Add the support to provide an optional label like we do for ADC
>>> channels to identify the device more easily.
>>>
>>> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
>>> ---
>>> Hi,
>>>
>>> patchset [1] should be applied first to avoid merge conflicts.
>>>
>>> [1] https://lore.kernel.org/all/20240219131114.134607-1-m.felsch@pengutronix.de/#t
>>>
>>> Regards,
>>> Marco
>>>
>>> .../devicetree/bindings/iio/temperature/ti,tmp117.yaml | 4 ++++
>>> 1 file changed, 4 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/iio/temperature/ti,tmp117.yaml b/Documentation/devicetree/bindings/iio/temperature/ti,tmp117.yaml
>>> index 33f2e9c5bd81..f00c1cb89acd 100644
>>> --- a/Documentation/devicetree/bindings/iio/temperature/ti,tmp117.yaml
>>> +++ b/Documentation/devicetree/bindings/iio/temperature/ti,tmp117.yaml
>>> @@ -27,6 +27,10 @@ properties:
>>> vcc-supply:
>>> description: provide VCC power to the sensor.
>>>
>>> + label:
>>> + $ref: /schemas/types.yaml#/definitions/string
>>
>> Drop ref. Did you take it from any existing binding?
>
> I used Documentation/devicetree/bindings/iio/adc/adc.yaml as reference.
I'll fix it there.
Anyway, label comes from iio schema in dtschema, so this should be just
"true".
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-02-26 12:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-23 16:20 [PATCH] dt-bindings: iio: ti,tmp117: add optional label binding Marco Felsch
2024-02-26 8:59 ` Krzysztof Kozlowski
2024-02-26 10:23 ` Marco Felsch
2024-02-26 12:42 ` Krzysztof Kozlowski [this message]
2024-02-26 12:56 ` Marco Felsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09f4b87e-8344-4051-aa69-5117f6c5e481@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=puranjay12@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.