Re: [PATCH] nfsv4: Add support for the birth time attribute

From: Chuck Lever III <chuck.lever@oracle.com>
To: Dan Shelton <dan.f.shelton@gmail.com>
Cc: Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] nfsv4: Add support for the birth time attribute
Date: Wed, 17 Jan 2024 02:54:07 +0000	[thread overview]
Message-ID: <0A8A7C46-F59D-4635-A4A9-55D297A9D01C@oracle.com> (raw)
In-Reply-To: <CAAvCNcCZ=uGxUN=9ztF6iOPsxdYUDYc2JeRrZxC4XPYOPW22uw@mail.gmail.com>

> On Jan 16, 2024, at 3:17 PM, Dan Shelton <dan.f.shelton@gmail.com> wrote:
> 
> On Tue, 16 Jan 2024 at 02:43, Chuck Lever III <chuck.lever@oracle.com> wrote:
>> 
>>> On Jan 15, 2024, at 8:02 PM, Dan Shelton <dan.f.shelton@gmail.com> wrote:
>>> 
>>> On Mon, 15 Jan 2024 at 07:37, Chen Hanxiao <chenhx.fnst@fujitsu.com> wrote:
>>>> 
>>>> This patch enable nfs to report btime in nfs_getattr.
>>>> If underlying filesystem supports "btime" timestamp,
>>>> statx will report btime for STATX_BTIME.
>>>> 
>>>> Signed-off-by: Chen Hanxiao <chenhx.fnst@fujitsu.com>
>>>> ---
>>>> v1:
>>>>   Don't revalidate btime attribute
>>>> 
>>>> RFC v2:
>>>>   properly set cache validity
>>>> 
>>>> fs/nfs/inode.c          | 23 ++++++++++++++++++++---
>>>> fs/nfs/nfs4proc.c       |  3 +++
>>>> fs/nfs/nfs4xdr.c        | 23 +++++++++++++++++++++++
>>>> include/linux/nfs_fs.h  |  2 ++
>>>> include/linux/nfs_xdr.h |  5 ++++-
>>>> 5 files changed, 52 insertions(+), 4 deletions(-)#
>>> 
>>> Hello
>>> 
>>> Where is the patch which adds support for btime to nfsd?
>> 
>> Support for the birth time attribute was added to NFSD two years
>> ago by commit e377a3e698fb ("nfsd: Add support for the birth
>> time attribute").
> 
> Which Linux versions (trunk, LTS, RT) have that commit?

e377a3e698fb was merged in v5.18. You'll also need these two fixes:

5b2f3e0777da ("NFSD: Decode NFSv4 birth time attribute") (v5.19)
d7dbed457c2e ("nfsd: Fix creation time serialization order") (v6.5)

All three of those commits should be in:

trunk: v6.5, v6.6, and v6.7
stable/LTS: origin/linux-6.6.y

I don't know which local file systems support birth time. I think
maybe ext4 and xfs do?

--
Chuck Lever