From: William Kucharski <william.kucharski@oracle.com>
To: Souptick Joarder <jrdr.linux@gmail.com>
Cc: Matthew Wilcox <willy@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@suse.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Dan Williams <dan.j.williams@intel.com>,
vbabka@suse.cz, riel@redhat.com, rppt@linux.ibm.com,
Linux-MM <linux-mm@kvack.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] mm: Create the new vm_fault_t type
Date: Wed, 14 Nov 2018 02:59:11 -0700 [thread overview]
Message-ID: <0EAE1409-DF80-4A9A-8936-C6E9BC7C9604@oracle.com> (raw)
In-Reply-To: <CAFqt6zbwwkvuZypssKQtsKdfZKk3DEQXpA7Qw6yDNakpu=Jv1w@mail.gmail.com>
> On Nov 13, 2018, at 10:13 PM, Souptick Joarder <jrdr.linux@gmail.com> wrote:
>
> On Tue, Nov 6, 2018 at 5:33 PM Souptick Joarder <jrdr.linux@gmail.com> wrote:
>>
>> Page fault handlers are supposed to return VM_FAULT codes,
>> but some drivers/file systems mistakenly return error
>> numbers. Now that all drivers/file systems have been converted
>> to use the vm_fault_t return type, change the type definition
>> to no longer be compatible with 'int'. By making it an unsigned
>> int, the function prototype becomes incompatible with a function
>> which returns int. Sparse will detect any attempts to return a
>> value which is not a VM_FAULT code.
>>
>> VM_FAULT_SET_HINDEX and VM_FAULT_GET_HINDEX values are changed
>> to avoid conflict with other VM_FAULT codes.
>>
>> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
>
> Any further comment on this patch ?
Reviewed-by: William Kucharski <william.kucharski@oracle.com>
next prev parent reply other threads:[~2018-11-14 9:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-06 12:06 [PATCH v3] mm: Create the new vm_fault_t type Souptick Joarder
2018-11-06 12:10 ` Michal Hocko
2018-11-14 5:13 ` Souptick Joarder
2018-11-14 9:59 ` William Kucharski [this message]
2018-11-15 1:47 ` Mike Rapoport
2018-11-24 4:46 ` Souptick Joarder
2018-12-14 5:05 ` Souptick Joarder
2019-01-07 6:17 ` Souptick Joarder
2019-01-07 6:17 ` Souptick Joarder
2019-01-07 22:44 ` Andrew Morton
2019-01-08 11:53 ` Souptick Joarder
2019-01-08 11:53 ` Souptick Joarder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0EAE1409-DF80-4A9A-8936-C6E9BC7C9604@oracle.com \
--to=william.kucharski@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=jrdr.linux@gmail.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=riel@redhat.com \
--cc=rppt@linux.ibm.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.