From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
alsa-devel@alsa-project.org
Cc: tiwai@suse.de, vinod.koul@intel.com, broonie@kernel.org,
jeremy@jcline.org, liam.r.girdwood@linux.intel.com
Subject: Re: [PATCH v3 1/2] ASoC: Intel: bytcht_es8316: fix HID handling
Date: Thu, 11 Jan 2018 15:56:53 -0600 [thread overview]
Message-ID: <0a56d149-5045-df4b-1489-93d902698426@linux.intel.com> (raw)
In-Reply-To: <1515701530.7000.932.camel@linux.intel.com>
On 1/11/18 2:12 PM, Andy Shevchenko wrote:
> On Thu, 2018-01-11 at 13:52 -0600, Pierre-Louis Bossart wrote:
>> Same problem as with previous machine drivers, the codec dai
>> uses a hard-coded name of "i2c-ESSX8316:00" but ACPI provides
>> "i2c-ESSX8316:01" in some systems.
>
>> static int snd_byt_cht_es8316_mc_probe(struct platform_device *pdev)
>> {
>> - int ret = 0;
>> struct byt_cht_es8316_private *priv;
>> + struct snd_soc_acpi_mach *mach;
>> + const char *i2c_name = NULL;
>> + int dai_index = 0;
>
>> + int i;
>
> A nit: unsigned int will look more natural here.
it'll go away in all machine drivers with the next cleanup (addition of
a helper)
>
>> + int ret = 0;
>
next prev parent reply other threads:[~2018-01-11 21:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-11 19:52 [PATCH v3 0/2] ASoC: Intel: ACPI-related fixes Pierre-Louis Bossart
2018-01-11 19:52 ` [PATCH v3 1/2] ASoC: Intel: bytcht_es8316: fix HID handling Pierre-Louis Bossart
2018-01-11 20:12 ` Andy Shevchenko
2018-01-11 21:56 ` Pierre-Louis Bossart [this message]
2018-01-11 19:52 ` [PATCH v3 2/2] ASoC: acpi: remove hard-coded i2c-device name length Pierre-Louis Bossart
2018-01-12 21:09 ` Applied "ASoC: acpi: remove hard-coded i2c-device name length" to the asoc tree Mark Brown
2018-01-11 20:13 ` [PATCH v3 0/2] ASoC: Intel: ACPI-related fixes Andy Shevchenko
2018-01-12 3:45 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a56d149-5045-df4b-1489-93d902698426@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=jeremy@jcline.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=tiwai@suse.de \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.