From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Damien Le Moal <damien.lemoal@opensource.wdc.com>,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
Jens Axboe <axboe@kernel.dk>
Cc: "Maciej S . Szmigiero" <mail@maciej.szmigiero.name>,
Hannes Reinecke <hare@suse.de>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v5 3/7] ata: libata: Rename and cleanup ata_rwcmd_protocol()
Date: Mon, 7 Nov 2022 05:43:11 +0000 [thread overview]
Message-ID: <0a5f6b7e-b462-2e1f-eb81-8eafea76391c@nvidia.com> (raw)
In-Reply-To: <20221107005021.1327692-4-damien.lemoal@opensource.wdc.com>
On 11/6/2022 4:50 PM, Damien Le Moal wrote:
> Rename ata_rwcmd_protocol() to ata_set_rwcmd_protocol() to better
> reflect the fact that this function sets a task file command and
> protocol. The arguments order is also reversed and the function return
> type changed to a bool to indicate if the command and protocol were set
> corretly (instead of returning a completely arbitrary "-1" value.
>
> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
> Reviewed-by: Hannes Reinecke <hare@suse.de>
This definitely makes than -1..
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
next prev parent reply other threads:[~2022-11-07 5:43 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-07 0:50 [PATCH v5 0/7] Improve libata support for FUA Damien Le Moal
2022-11-07 0:50 ` [PATCH v5 1/7] block: add a sanity check for non-write flush/fua bios Damien Le Moal
2022-11-07 5:40 ` Chaitanya Kulkarni
2022-11-07 10:23 ` Hannes Reinecke
2022-11-07 0:50 ` [PATCH v5 2/7] ata: libata: Introduce ata_ncq_supported() Damien Le Moal
2022-11-07 5:41 ` Chaitanya Kulkarni
2022-11-07 5:46 ` Christoph Hellwig
2022-11-07 0:50 ` [PATCH v5 3/7] ata: libata: Rename and cleanup ata_rwcmd_protocol() Damien Le Moal
2022-11-07 5:43 ` Chaitanya Kulkarni [this message]
2022-11-07 5:47 ` Christoph Hellwig
2022-11-07 0:50 ` [PATCH v5 4/7] ata: libata: cleanup fua support detection Damien Le Moal
2022-11-07 5:44 ` Chaitanya Kulkarni
2022-11-07 5:48 ` Christoph Hellwig
2022-11-07 0:50 ` [PATCH v5 5/7] ata: libata: Fix FUA handling in ata_build_rw_tf() Damien Le Moal
2022-11-07 5:45 ` Chaitanya Kulkarni
2022-11-07 5:50 ` Christoph Hellwig
2022-11-07 12:12 ` Damien Le Moal
2022-11-07 12:16 ` Christoph Hellwig
2022-11-07 12:32 ` Damien Le Moal
2022-11-08 5:53 ` Damien Le Moal
2022-11-07 0:50 ` [PATCH v5 6/7] ata: libata: blacklist FUA support for known buggy drives Damien Le Moal
2022-11-07 5:46 ` Chaitanya Kulkarni
2022-11-07 5:50 ` Christoph Hellwig
2022-11-07 0:50 ` [PATCH v5 7/7] ata: libata: Enable fua support by default Damien Le Moal
2022-11-07 5:47 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a5f6b7e-b462-2e1f-eb81-8eafea76391c@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@opensource.wdc.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=mail@maciej.szmigiero.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.