Re: [PATCH v3 1/3] dt-bindings: spi: add spi-rx-bus-channels peripheral property

From: Mark Brown <broonie@kernel.org>
To: David Lechner <dlechner@baylibre.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
	linux-iio@vger.kernel.org, linux-spi@vger.kernel.org,
	devicetree@vger.kernel.org, "Rob Herring" <robh+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Michael Hennerich" <michael.hennerich@analog.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Liam Girdwood" <lgirdwood@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/3] dt-bindings: spi: add spi-rx-bus-channels peripheral property
Date: Mon, 8 Jan 2024 16:39:43 +0000	[thread overview]
Message-ID: <0a774bc6-3bf9-4b5f-92e0-8bd673e71a33@sirena.org.uk> (raw)
In-Reply-To: <CAMknhBE7eUMzcD0bdymrhL2Lw3FubB3aHDWmJFD7YnaGNYmQ9w@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1384 bytes --]

On Sun, Jan 07, 2024 at 05:02:56PM -0600, David Lechner wrote:
> On Sun, Jan 7, 2024 at 3:27 PM Mark Brown <broonie@kernel.org> wrote:

> > This makes no sense to me without a corresponding change in the SPI core
> > and possibly controller support, though I guess you could do data
> > manging to rewrite from a normal parallel SPI to this for a pure
> > software implementation.  I also see nothing in the driver that even
> > attempts to parse this so I can't see how it could possibly work.

> We currently don't have a controller that supports this. This is just
> an attempt to make a complete binding for a peripheral according to
> [2] which says:

...

> So, will DT maintainers accept an incomplete binding for the
> peripheral? Or will you reconsider this without SPI core support if I
> can explain it better? It doesn't seem like a reasonable request to
> expect us to spend time developing software that we don't need at this
> time just to get a complete DT binding accepted for a feature that
> isn't being used.

I don't think it's sensible to try to make a binding for this without
having actually tried to put a system together that uses it and made
sure that everything is joined up properly, the thing about complete
bindings is more for things that are handle turning than for things that
are substantial new features in subsystems.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]