Re: [PATCH v3 1/2] dt-bindings: input: Add Himax HX83102J touchscreen

From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Allen Lin <allencl_lin@hotmail.com>
Cc: dmitry.torokhov@gmail.com, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	jikos@kernel.org, benjamin.tissoires@redhat.com,
	linux-input@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: input: Add Himax HX83102J touchscreen
Date: Sat, 30 Dec 2023 15:19:05 +0100	[thread overview]
Message-ID: <0a817121-620c-4630-93a3-5cf3173b924f@linaro.org> (raw)
In-Reply-To: <TY0PR06MB561188EBD127F8ECF4A7052B9E9DA@TY0PR06MB5611.apcprd06.prod.outlook.com>

On 29/12/2023 10:08, Allen Lin wrote:
> Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> 於 2023年12月28日 週四 下午6:36寫道：
>>
>> On 27/12/2023 06:35, Allen_Lin wrote:
>>> Add the HX83102j touchscreen device tree bindings documents.
>>>
>>> Signed-off-by: Allen_Lin <allencl_lin@hotmail.com>
>>> ---
>>
>> Where is the changelog? There is no cover letter attached, so changelog
>> is supposed to be here. There were several comments, so does it mean you
>> ignored them?
>>
> Cover letter is not in this mail but in the mail with this title
> "[PATCH v3 0/2] Add HX83102j driver for HIMAX HID touchscreen"

There was no cover letter attached to this thread. Don't send cover
letters in separate threads.

> 
> Hi,
> This driver implements for Himax HID touchscreen HX83102j.
> 
> Using SPI interface to receive/send HID packets.
> 
> Patchs notes as below
> 1. Add the Maintainer and devicetree bindings document for driver
> 2. Add the driver code and modify Kconfig/Makefile to support the driver
> 
> change in v2 :
> - Fix kernel test robot build warnings.
> change in v3 :
> - Modify code according to review suggesions.

Not detailed enough. What did you change exactly?

Best regards,
Krzysztof