From: Mike Kravetz <mike.kravetz@oracle.com>
To: Miaohe Lin <linmiaohe@huawei.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hugetlbfs: Use helper macro default_hstate in init_hugetlbfs_fs
Date: Tue, 19 Jan 2021 09:53:18 -0800 [thread overview]
Message-ID: <0aa2f156-a2c9-3b2e-4244-ecf68208b4a0@oracle.com> (raw)
In-Reply-To: <20210116091827.20982-1-linmiaohe@huawei.com>
On 1/16/21 1:18 AM, Miaohe Lin wrote:
> Since commit e5ff215941d5 ("hugetlb: multiple hstates for multiple page
> sizes"), we can use macro default_hstate to get the struct hstate which
> we use by default. But init_hugetlbfs_fs() forgot to use it.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Thanks,
Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
--
Mike Kravetz
> ---
> fs/hugetlbfs/inode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c
> index 9b221b87fbea..88751e35e69d 100644
> --- a/fs/hugetlbfs/inode.c
> +++ b/fs/hugetlbfs/inode.c
> @@ -1544,7 +1544,7 @@ static int __init init_hugetlbfs_fs(void)
> goto out_free;
>
> /* default hstate mount is required */
> - mnt = mount_one_hugetlbfs(&hstates[default_hstate_idx]);
> + mnt = mount_one_hugetlbfs(&default_hstate);
> if (IS_ERR(mnt)) {
> error = PTR_ERR(mnt);
> goto out_unreg;
>
next prev parent reply other threads:[~2021-01-19 19:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-16 9:18 [PATCH] hugetlbfs: Use helper macro default_hstate in init_hugetlbfs_fs Miaohe Lin
2021-01-18 9:57 ` David Hildenbrand
2021-01-19 17:53 ` Mike Kravetz [this message]
2021-01-19 18:11 ` Mike Kravetz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0aa2f156-a2c9-3b2e-4244-ecf68208b4a0@oracle.com \
--to=mike.kravetz@oracle.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.