Re: [PATCH v3 0/4] platform/x86/amd/pmf: Fix policy binary handling

From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
Cc: Armin Wolf <W_Armin@gmx.de>, Hans de Goede <hdegoede@redhat.com>,
	 platform-driver-x86@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 0/4] platform/x86/amd/pmf: Fix policy binary handling
Date: Wed, 6 Mar 2024 11:53:14 +0200 (EET)	[thread overview]
Message-ID: <0b614744-257b-3d4f-533e-f8bf9085f03a@linux.intel.com> (raw)
In-Reply-To: <839a74c1-6e08-441b-a6e3-9923dfc3f303@amd.com>

On Wed, 6 Mar 2024, Shyam Sundar S K wrote:
> On 3/5/2024 02:20, Armin Wolf wrote:
> > This patch series fixes various issues inside the policy binary
> > handling code.
> > The first patch makes sure that a valid error code is returned upon
> > failing to start the policy engine, while the second patch drops the
> > usage of readl() on non-io memory.
> > The last two patches fix a possible out-of-bounds memory access when
> > parsing the policy binary header.
> > 
> > All patches are compile-tested only.
> > 
> > Changes since v2:
> > - add patches 1 and 3
> > 
> > Changes since v1:
> > - get the full dword instead of only 8 bits when reading the header
> > - check if the policy buffer also has enough room for storing the length
> 
> Thank you Armin. Series looks good to me.
> 
> Reviewed-by: Shyam Sundar S K Shyam-sundar.S-k@amd.com

Thanks for taking a look.

Btw, you were missing <> around the address so the patchwork automation 
didn't catch that line. To help the patchwork to capture that tag (no need 
for you to do anything):

Reviewed-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>

--
 i.

> > Armin Wolf (4):
> >   platform/x86/amd/pmf: Fix return value of
> >     amd_pmf_start_policy_engine()
> >   platform/x86/amd/pmf: Do not use readl() for policy buffer access
> >   platform/x86/amd/pmf: Use struct for cookie header
> >   platform/x86/amd/pmf: Fix possible out-of-bound memory accesses