From: Xiaoguang Wang <xiaoguang.wang@linux.alibaba.com>
To: Jens Axboe <axboe@kernel.dk>, io-uring@vger.kernel.org
Cc: asml.silence@gmail.com
Subject: Re: [PATCH] io_uring: fix missing sigmask restore in io_cqring_wait()
Date: Tue, 14 Sep 2021 22:53:17 +0800 [thread overview]
Message-ID: <0b734068-51d8-2442-74ff-620891fc5502@linux.alibaba.com> (raw)
In-Reply-To: <d5e72e5f-5653-f738-f675-9ac955d7e55e@kernel.dk>
hi,
> On 9/14/21 8:38 AM, Xiaoguang Wang wrote:
>> Move get_timespec() section in io_cqring_wait() before the sigmask
>> saving, otherwise we'll fail to restore sigmask once get_timespec()
>> returns error.
> Applied, thanks! I added a:
>
> Fixes: c73ebb685fb6 ("io_uring: add timeout support for io_uring_enter()")
>
> to the commit since that's when it got broken, that'll help with
> stable backports. Not that it's a _huge_ issue, it basically means
> the application is broken anyway.
Agree, thanks.
Regards,
Xiaoguang Wang
>
prev parent reply other threads:[~2021-09-14 14:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-14 14:38 [PATCH] io_uring: fix missing sigmask restore in io_cqring_wait() Xiaoguang Wang
2021-09-14 14:47 ` Jens Axboe
2021-09-14 14:53 ` Xiaoguang Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b734068-51d8-2442-74ff-620891fc5502@linux.alibaba.com \
--to=xiaoguang.wang@linux.alibaba.com \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.