From: Costin Lupu <costin.lupu@cs.pub.ro>
To: Christian Lindig <christian.lindig@citrix.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"Tim (Xen.org)" <tim@xen.org>, Ian Jackson <iwj@xenproject.org>,
Wei Liu <wl@xen.org>, David Scott <dave@recoil.org>
Subject: Re: [PATCH 0/5] Fix redefinition errors for toolstack libs
Date: Wed, 28 Apr 2021 21:37:30 +0300 [thread overview]
Message-ID: <0b82dc88-fe59-3074-471f-2e36ba3b840e@cs.pub.ro> (raw)
In-Reply-To: <AE965271-FE62-4EA7-91CC-F6438C34962A@citrix.com>
On 4/28/21 3:34 PM, Christian Lindig wrote:
>
>
>> On 27 Apr 2021, at 13:05, Costin Lupu <costin.lupu@cs.pub.ro
>> <mailto:costin.lupu@cs.pub.ro>> wrote:
>>
>> For replication I used gcc 10.3 on an Alpine system. In order to
>> replicate the
>> redefinition error for PAGE_SIZE one should install the 'fortify-headers'
>> package which will change the chain of included headers by indirectly
>> including
>> /usr/include/limits.h where PAGE_SIZE and PATH_MAX are defined.
>>
>> Costin Lupu (5):
>> tools/debugger: Fix PAGE_SIZE redefinition error
>> tools/libfsimage: Fix PATH_MAX redefinition error
>> tools/libs/foreignmemory: Fix PAGE_SIZE redefinition error
>> tools/libs/gnttab: Fix PAGE_SIZE redefinition error
>> tools/ocaml: Fix redefinition errors
>>
>> tools/debugger/kdd/kdd-xen.c | 4 ++++
>> tools/debugger/kdd/kdd.c | 4 ++++
>> tools/libfsimage/ext2fs/fsys_ext2fs.c | 2 ++
>> tools/libfsimage/reiserfs/fsys_reiserfs.c | 2 ++
>> tools/libs/foreignmemory/private.h | 6 ++++--
>> tools/libs/gnttab/linux.c | 6 ++++++
>> tools/ocaml/libs/xc/xenctrl_stubs.c | 8 ++++++++
>> tools/ocaml/libs/xentoollog/xentoollog_stubs.c | 4 ++++
>> tools/ocaml/libs/xl/xenlight_stubs.c | 4 ++++
>> 9 files changed, 38 insertions(+), 2 deletions(-)
>>
>> —
>> 2.20.1
>>
>
> For the OCaml bindings, this avoids redefinitions as you say. Looks good
> to me.
>
> Acked-by: Christian Lindig <christian.lindig@citrix.com
> <mailto:christian.lindig@citrix.com>>
>
Thanks, Christian, I'll add your ack on the Ocaml patch for the next
version of the series.
Cheers,
Costin
prev parent reply other threads:[~2021-04-28 18:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-27 12:05 [PATCH 0/5] Fix redefinition errors for toolstack libs Costin Lupu
2021-04-27 12:05 ` [PATCH 1/5] tools/debugger: Fix PAGE_SIZE redefinition error Costin Lupu
2021-04-29 19:58 ` Tim Deegan
2021-04-30 11:36 ` Costin Lupu
2021-04-30 18:45 ` Tim Deegan
2021-04-30 19:33 ` Costin Lupu
2021-04-27 12:05 ` [PATCH 2/5] tools/libfsimage: Fix PATH_MAX " Costin Lupu
2021-04-28 9:04 ` Julien Grall
2021-04-28 18:35 ` Costin Lupu
2021-04-29 11:39 ` Julien Grall
2021-04-27 12:05 ` [PATCH 3/5] tools/libs/foreignmemory: Fix PAGE_SIZE " Costin Lupu
2021-04-28 9:03 ` Julien Grall
2021-04-28 18:27 ` Costin Lupu
2021-04-29 11:29 ` Julien Grall
2021-04-27 12:05 ` [PATCH 4/5] tools/libs/gnttab: " Costin Lupu
2021-04-27 12:05 ` [PATCH 5/5] tools/ocaml: Fix redefinition errors Costin Lupu
2021-04-28 12:34 ` [PATCH 0/5] Fix redefinition errors for toolstack libs Christian Lindig
2021-04-28 18:37 ` Costin Lupu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b82dc88-fe59-3074-471f-2e36ba3b840e@cs.pub.ro \
--to=costin.lupu@cs.pub.ro \
--cc=christian.lindig@citrix.com \
--cc=dave@recoil.org \
--cc=iwj@xenproject.org \
--cc=tim@xen.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.