All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Oleksii Kurochko <oleksii.kurochko@gmail.com>,
	Shawn Anastasio <sanastasio@raptorengineering.com>,
	Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] xen/{RISCV,PPC}/xen.lds: Delete duplicate _erodata definitions
Date: Tue, 5 Mar 2024 12:59:54 +0000	[thread overview]
Message-ID: <0c0d350c-8b87-4870-aea8-6f9856009ce7@citrix.com> (raw)
In-Reply-To: <f6ddaaf3-8c55-4155-9924-861b356f61dc@suse.com>

On 05/03/2024 12:44 pm, Jan Beulich wrote:
> On 05.03.2024 13:21, Andrew Cooper wrote:
>> This is bad copy/paste from somewhere.  Retain the second _erodata symbol,
>> which follows the Build ID, and matches the other architectures.
>>
>> No functional change.
> I.e. the 2nd one took effect?

Seems to have done, yes.

>  (To be honest I'm surprised the linker
> didn't complain about a duplicate symbol there.)
>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Reviewed-by: Jan Beulich <jbeulich@suse.com>

Thanks.




  reply	other threads:[~2024-03-05 13:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-05 12:21 [PATCH] xen/{RISCV,PPC}/xen.lds: Delete duplicate _erodata definitions Andrew Cooper
2024-03-05 12:44 ` Jan Beulich
2024-03-05 12:59   ` Andrew Cooper [this message]
2024-03-05 14:59 ` Oleksii
2024-03-05 17:38 ` Shawn Anastasio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0c0d350c-8b87-4870-aea8-6f9856009ce7@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=jbeulich@suse.com \
    --cc=oleksii.kurochko@gmail.com \
    --cc=sanastasio@raptorengineering.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.