From: Yicong Yang <yangyicong@hisilicon.com>
To: Lukas Wunner <lukas@wunner.de>, Bjorn Helgaas <helgaas@kernel.org>
Cc: <linux-pci@vger.kernel.org>,
<sathyanarayanan.kuppuswamy@linux.intel.com>, <kbusch@kernel.org>,
<sean.v.kelley@intel.com>, <qiuxu.zhuo@intel.com>,
<prime.zeng@huawei.com>, <linuxarm@openeuler.org>
Subject: Re: [PATCH] PCI/DPC: Disable ERR_COR explicitly for native dpc service
Date: Mon, 12 Apr 2021 17:32:32 +0800 [thread overview]
Message-ID: <0c3faac2-6b22-ab04-a145-99c29dd240e2@hisilicon.com> (raw)
In-Reply-To: <20210410191749.GA16240@wunner.de>
On 2021/4/11 3:17, Lukas Wunner wrote:
> On Sat, Apr 10, 2021 at 10:21:03AM -0500, Bjorn Helgaas wrote:
>> Anybody want to chime in and review this? Sometimes I feel like a
>> one-man band :)
>
> Can't say anything about the object of the patch, but style-wise
> this looks cryptic:
>
>>> --- a/drivers/pci/pcie/dpc.c
>>> +++ b/drivers/pci/pcie/dpc.c
>>> @@ -302,7 +302,7 @@ static int dpc_probe(struct pcie_device *dev)
>>> pci_read_config_word(pdev, pdev->dpc_cap + PCI_EXP_DPC_CTL, &ctl);
>>>
>>> - ctl = (ctl & 0xfff4) | PCI_EXP_DPC_CTL_EN_FATAL | PCI_EXP_DPC_CTL_INT_EN;
>>> + ctl = (ctl & 0xffe4) | PCI_EXP_DPC_CTL_EN_FATAL | PCI_EXP_DPC_CTL_INT_EN;
>>> pci_write_config_word(pdev, pdev->dpc_cap + PCI_EXP_DPC_CTL, ctl);
>
> Instead of writing "ctl & 0xfff4", I'd prefer defining macros for the
> register bits of interest, then use "ctl &= ~(u16)(bits to clear)"
> and in a separate line use "ctl |= (bits to set)".
>
yes. that's clearer. I'll use macros if we're going to have this patch.
> Obviously, clearing bits that are unconditionally set afterwards is
> unnecessary (as is done here).
>
ok. I found this when I read the Spec and thought it might be sanity
to ensure the bit is not set.
>
>>> pci_info(pdev, "enabled with IRQ %d\n", dev->irq);
>
> This looks superfluous since the IRQ can be found out in /proc/interrupts.
this can help us track dpc interrupts on certain ports through /proc/interrupts,
as all the dpc interrupts are named 'pcie-dpc' and its hard to distinguish.
Thanks,
Yicong
>
> Thanks,
>
> Lukas
>
> .
>
next prev parent reply other threads:[~2021-04-12 9:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 12:53 [PATCH v2] PCI/DPC: Check host->native_dpc before enable dpc service Yicong Yang
2021-02-03 12:53 ` [PATCH] PCI/DPC: Disable ERR_COR explicitly for native " Yicong Yang
2021-02-18 17:20 ` Bjorn Helgaas
2021-02-24 8:56 ` Yicong Yang
2021-04-10 15:21 ` Bjorn Helgaas
2021-04-10 19:17 ` Lukas Wunner
2021-04-12 9:32 ` Yicong Yang [this message]
2021-04-12 3:32 ` Kuppuswamy, Sathyanarayanan
2021-04-12 9:46 ` Yicong Yang
2021-02-24 9:47 ` [PATCH v2] PCI/DPC: Check host->native_dpc before enable " Yicong Yang
2021-07-26 22:05 ` Bjorn Helgaas
2021-07-28 9:22 ` Yicong Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c3faac2-6b22-ab04-a145-99c29dd240e2@hisilicon.com \
--to=yangyicong@hisilicon.com \
--cc=helgaas@kernel.org \
--cc=kbusch@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxarm@openeuler.org \
--cc=lukas@wunner.de \
--cc=prime.zeng@huawei.com \
--cc=qiuxu.zhuo@intel.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=sean.v.kelley@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.