From: Lars-Peter Clausen <lars@metafoo.de>
To: Andriy Tryshnivskyy <andriy.tryshnivskyy@opensynergy.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Vasyl.Vavrychuk@opensynergy.com, jbhayana@google.com,
Jonathan Cameron <jic23@kernel.org>,
linux-iio <linux-iio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v7 3/3] iio: test: Add test for IIO_VAL_INT_64.
Date: Fri, 5 Nov 2021 09:50:51 +0100 [thread overview]
Message-ID: <0c449b88-a6fb-76ca-5c13-807f7728f1da@metafoo.de> (raw)
In-Reply-To: <6d909cca-46a9-3f40-5d4d-97ef2fbe33e9@opensynergy.com>
On 11/5/21 9:45 AM, Andriy Tryshnivskyy wrote:
> On 02.11.21 10:11, Andy Shevchenko wrote:
>
>> CAUTION: This email originated from outside of the organization.
>> Do not click links or open attachments unless you recognize the
>> sender and know the content is safe.
>>
>>
>> On Tue, Nov 2, 2021 at 9:33 AM Andriy Tryshnivskyy
>> <andriy.tryshnivskyy@opensynergy.com> wrote:
>> Now it's good with format, but you have missed the commit message.
>
> Actually commit massage contains a header only (no body message), but
> I can add body message too.
> Thanks!
>
>>
>>> Signed-off-by: Andriy Tryshnivskyy
>>> <andriy.tryshnivskyy@opensynergy.com>
>> ...
>>
>>> +static void iio_test_iio_format_value_integer_64(struct kunit *test)
>>> +{
>>> + char *buf = kunit_kmalloc(test, PAGE_SIZE, GFP_KERNEL);
>> Shouldn't this be checked against NULL?
>
> Good question. Truly speaking I've made new test similar to other. And
> no other tests has a check for NULL.
>
The other tests not having it is my fault. There should be a
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, buf) under the allocation.
next prev parent reply other threads:[~2021-11-05 8:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-24 9:16 [PATCH v7 0/2] iio/scmi: Add reading "raw" attribute Andriy Tryshnivskyy
2021-10-24 9:16 ` [PATCH v7 1/2] iio: core: Introduce IIO_VAL_INT_64 Andriy Tryshnivskyy
2021-10-24 16:10 ` Jonathan Cameron
2021-10-24 16:58 ` Andriy Tryshnivskyy
2021-10-30 14:47 ` Jonathan Cameron
2021-11-01 7:28 ` Andriy Tryshnivskyy
2021-11-01 13:54 ` Andriy Tryshnivskyy
2021-11-01 14:23 ` Andy Shevchenko
2021-11-02 7:33 ` [PATCH v7 3/3] iio: test: Add test for IIO_VAL_INT_64 Andriy Tryshnivskyy
2021-11-02 8:11 ` Andy Shevchenko
2021-11-05 8:45 ` Andriy Tryshnivskyy
2021-11-05 8:50 ` Lars-Peter Clausen [this message]
2021-11-05 8:55 ` Andriy Tryshnivskyy
2021-11-05 9:04 ` Lars-Peter Clausen
2021-10-24 9:16 ` [PATCH v7 2/2] iio/scmi: Add reading "raw" attribute Andriy Tryshnivskyy
2021-10-28 14:08 ` Jonathan Cameron
2021-10-28 18:52 ` Jyoti Bhayana
2021-10-30 14:49 ` [PATCH v7 0/2] " Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c449b88-a6fb-76ca-5c13-807f7728f1da@metafoo.de \
--to=lars@metafoo.de \
--cc=Vasyl.Vavrychuk@opensynergy.com \
--cc=andriy.tryshnivskyy@opensynergy.com \
--cc=andy.shevchenko@gmail.com \
--cc=jbhayana@google.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.