From: Richard Henderson <richard.henderson@linaro.org>
To: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org
Cc: dinechin@redhat.com, "Paolo Bonzini" <pbonzini@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>
Subject: Re: [PATCH v4 1/7] qdev: add support for device module loading
Date: Fri, 26 Jun 2020 11:46:47 -0700 [thread overview]
Message-ID: <0d4b0c31-b623-6e42-eca2-312908fda360@linaro.org> (raw)
In-Reply-To: <20200622135601.12433-2-kraxel@redhat.com>
On 6/22/20 6:55 AM, Gerd Hoffmann wrote:
> @@ -147,6 +150,9 @@ DeviceState *qdev_new(const char *name)
> */
> DeviceState *qdev_try_new(const char *name)
> {
> + if (!object_class_by_name(name)) {
> + qdev_module_load_type(name);
> + }
> if (!object_class_by_name(name)) {
> return NULL;
> }
The second if can be nested inside the first.
Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2020-06-26 18:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-22 13:55 [PATCH v4 0/7] build some devices as modules Gerd Hoffmann
2020-06-22 13:55 ` [PATCH v4 1/7] qdev: add support for device module loading Gerd Hoffmann
2020-06-26 18:46 ` Richard Henderson [this message]
2020-06-22 13:55 ` [PATCH v4 2/7] build: fix device module builds Gerd Hoffmann
2020-06-22 13:55 ` [PATCH v4 3/7] ccid: build smartcard as module Gerd Hoffmann
2020-06-23 15:28 ` Philippe Mathieu-Daudé
2020-06-23 17:12 ` Gerd Hoffmann
2020-06-30 9:44 ` Philippe Mathieu-Daudé
2020-06-30 16:07 ` Gerd Hoffmann
2020-06-30 16:24 ` Daniel P. Berrangé
2020-06-22 13:55 ` [PATCH v4 4/7] usb: build usb-redir " Gerd Hoffmann
2020-06-22 13:55 ` [PATCH v4 5/7] vga: build qxl " Gerd Hoffmann
2020-06-22 13:56 ` [PATCH v4 6/7] vga: build virtio-gpu only once Gerd Hoffmann
2020-06-22 13:56 ` [PATCH v4 7/7] vga: build virtio-gpu as module Gerd Hoffmann
2020-06-23 15:04 ` [PATCH v4 0/7] build some devices as modules Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d4b0c31-b623-6e42-eca2-312908fda360@linaro.org \
--to=richard.henderson@linaro.org \
--cc=berrange@redhat.com \
--cc=dinechin@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.