Re: [ndctl PATCH] cxl/monitor: Make libtracefs dependency optional

From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "Williams, Dan J" <dan.j.williams@intel.com>,
	"a.manzanares@samsung.com" <a.manzanares@samsung.com>
Cc: "linux-cxl@vger.kernel.org" <linux-cxl@vger.kernel.org>
Subject: Re: [ndctl PATCH] cxl/monitor: Make libtracefs dependency optional
Date: Fri, 24 Feb 2023 00:18:35 +0000	[thread overview]
Message-ID: <0daf23ea2d52bfebbaaae76f461dd8566df4961d.camel@intel.com> (raw)
In-Reply-To: <20230223232817.GA469785@bgt-140510-bm01>

On Thu, 2023-02-23 at 23:28 +0000, Adam Manzanares wrote:
> On Thu, Feb 23, 2023 at 12:29:02PM -0800, Dan Williams wrote:
> > Build a stub version of 'cxl monitor' that reports that the facility was
> > statically disabled at configure / build time. Provide the meson
> > configuration line to correct the build.
> > 
> > This is in response to the fact that some distros fail to ship
> > libtracefs-devel even though they ship libtracefs (looking at you CentOS
> > Stream 8).
> > 
> > Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> > ---
> >  config.h.meson    |    3 +++
> >  cxl/builtin.h     |    9 +++++++++
> >  cxl/meson.build   |   33 +++++++++++++++++++++------------
> >  meson.build       |    7 +++++--
> >  meson_options.txt |    1 +
> >  ndctl.spec.in     |    8 +++++---
> >  6 files changed, 44 insertions(+), 17 deletions(-)
> 

<..>

> Heads up, I just built ndctl devel branch on tumbleweed and libtracefs-dev
> puts include files in libtracefs/tracefs.h

Yep this was reported earlier today:
https://github.com/pmem/ndctl/issues/234

I'll have a fix and a 76.1 release with these shortly!