Re: [PATCH] platform/x86: intel-uncore-frequency: use default_groups in kobj_type

From: Hans de Goede <hdegoede@redhat.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org
Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	Mark Gross <markgross@kernel.org>,
	platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH] platform/x86: intel-uncore-frequency: use default_groups in kobj_type
Date: Thu, 30 Dec 2021 19:34:23 +0100	[thread overview]
Message-ID: <0e54f409-1f9e-00ec-8045-5a614197ebcf@redhat.com> (raw)
In-Reply-To: <20211229141454.2552950-1-gregkh@linuxfoundation.org>

Hi,

On 12/29/21 15:14, Greg Kroah-Hartman wrote:
> There are currently 2 ways to create a set of sysfs files for a
> kobj_type, through the default_attrs field, and the default_groups
> field.  Move the uncore-frequency sysfs code to use default_groups field
> which has been the preferred way since aa30f47cf666 ("kobject: Add
> support for default attribute groups to kobj_type") so that we can soon
> get rid of the obsolete default_attrs field.
> 
> Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: Mark Gross <markgross@kernel.org>
> Cc: platform-driver-x86@vger.kernel.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Thank you for your patch, I've applied this patch to my review-hans 
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans

> ---
>  drivers/platform/x86/intel/uncore-frequency.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/intel/uncore-frequency.c b/drivers/platform/x86/intel/uncore-frequency.c
> index 3ee4c5c8a64f..4cd8254f2e40 100644
> --- a/drivers/platform/x86/intel/uncore-frequency.c
> +++ b/drivers/platform/x86/intel/uncore-frequency.c
> @@ -225,6 +225,7 @@ static struct attribute *uncore_attrs[] = {
>  	&min_freq_khz.attr,
>  	NULL
>  };
> +ATTRIBUTE_GROUPS(uncore);
>  
>  static void uncore_sysfs_entry_release(struct kobject *kobj)
>  {
> @@ -236,7 +237,7 @@ static void uncore_sysfs_entry_release(struct kobject *kobj)
>  static struct kobj_type uncore_ktype = {
>  	.release = uncore_sysfs_entry_release,
>  	.sysfs_ops = &kobj_sysfs_ops,
> -	.default_attrs = uncore_attrs,
> +	.default_groups = uncore_groups,
>  };
>  
>  /* Caller provides protection */
> 