RE: [PATCH rdma-next] irdma: Store PBL info address a pointer type

From: "Saleem, Shiraz" <shiraz.saleem@intel.com>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: "dledford@redhat.com" <dledford@redhat.com>,
	"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
	lkp <lkp@intel.com>,
	"Nikolova, Tatyana E" <tatyana.e.nikolova@intel.com>,
	"Ismail, Mustafa" <mustafa.ismail@intel.com>
Subject: RE: [PATCH rdma-next] irdma: Store PBL info address a pointer type
Date: Thu, 10 Jun 2021 12:49:30 +0000	[thread overview]
Message-ID: <0e8c2d1c2c9a47da971a0b6b9e22f208@intel.com> (raw)
In-Reply-To: <20210610124454.GA1264557@nvidia.com>

Shiraz Saleem
Network Software Engineer
Networking Division (DPG/CG/EPG)
Intel Corporation
Mobile: 1-617-633-1629

> -----Original Message-----
> From: Jason Gunthorpe <jgg@nvidia.com>
> Sent: Thursday, June 10, 2021 7:45 AM
> To: Saleem, Shiraz <shiraz.saleem@intel.com>
> Cc: dledford@redhat.com; linux-rdma@vger.kernel.org; lkp <lkp@intel.com>
> Subject: Re: [PATCH rdma-next] irdma: Store PBL info address a pointer type
> 
> On Wed, Jun 09, 2021 at 06:49:24PM -0500, Shiraz Saleem wrote:
> > The level1 PBL info address is stored as u64.
> > This requires casting through a uinptr_t before used as a pointer
> > type.
> >
> > And this leads to sparse warning such as this when uinptr_t is
> > missing:
> >
> > drivers/infiniband/hw/irdma/hw.c: In function 'irdma_destroy_virt_aeq':
> > drivers/infiniband/hw/irdma/hw.c:579:23: warning: cast to pointer from integer of
> different size [-Wint-to-pointer-cast]
> >   579 |  dma_addr_t *pg_arr = (dma_addr_t *)aeq->palloc.level1.addr;
> >
> > This can be fixed using an intermediate uintptr_t, but rather it is
> > better to fix the structure irdm_pble_info to store the address as
> > u64* and the VA it is assigned in irdma_chunk as a void*. This greatly
> > reduces the casting on this address.
> >
> > Fixes: 44d9e52977a1 ("RDMA/irdma: Implement device initialization
> > definitions")
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: Shiraz Saleem <shiraz.saleem@intel.com>
> > ---
> >  drivers/infiniband/hw/irdma/hw.c    |  2 +-
> >  drivers/infiniband/hw/irdma/pble.c  | 13 ++++++-------
> > drivers/infiniband/hw/irdma/pble.h  |  6 +++---
> > drivers/infiniband/hw/irdma/utils.c | 10 +++++-----
> > drivers/infiniband/hw/irdma/verbs.c | 16 ++++++++--------
> >  5 files changed, 23 insertions(+), 24 deletions(-)
> 
> Applied to for-next, but please be careful with the commit messages, the tag
> should be 'RDMA/irdma' and word wrap to the standard 74 cols, not alot less. I
> fixed it up
> 

I see. Thanks!