From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: sanyog.r.kale@intel.com,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
alsa-devel@alsa-project.org
Subject: Re: [PATCH 2/4] soundwire: cdns: fix check for number of messages
Date: Fri, 29 Mar 2019 10:06:32 +0000 [thread overview]
Message-ID: <0e99ce6b-af40-df7b-9548-0055261c6440@linaro.org> (raw)
In-Reply-To: <20190329055446.GJ5348@vkoul-mobl>
On 29/03/2019 05:54, Vinod Koul wrote:
>>> is that the defer structure is actually modified below this code (not
>>> shown in the diff) to set defer>length = msg->len, so testing before the
>>> value is set looks more suspicious than the current code.
>> removing the length field in defer should get rid of such instances.
> Right!
I will go ahead and post the cleanup patch to get rid of
confusing/redundant length field in defer.
Thanks,
srini
next prev parent reply other threads:[~2019-03-29 10:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-28 13:41 [PATCH 0/4] soundwire: few trival fixes and cleanups Srinivas Kandagatla
2019-03-28 13:41 ` [PATCH 1/4] soundwire: add module_sdw_driver helper macro Srinivas Kandagatla
2019-03-29 5:38 ` Vinod Koul
2019-03-28 13:41 ` [PATCH 2/4] soundwire: cdns: fix check for number of messages Srinivas Kandagatla
2019-03-28 14:03 ` Pierre-Louis Bossart
2019-03-28 14:58 ` Srinivas Kandagatla
2019-03-29 3:51 ` Sanyog Kale
2019-03-29 5:54 ` Vinod Koul
2019-03-29 10:06 ` Srinivas Kandagatla [this message]
2019-03-28 13:41 ` [PATCH 3/4] soundwire: bus: check if pm runtime is enabled before calling Srinivas Kandagatla
2019-03-28 13:55 ` Pierre-Louis Bossart
2019-03-28 14:37 ` Srinivas Kandagatla
2019-03-29 5:58 ` Vinod Koul
2019-03-29 10:02 ` Srinivas Kandagatla
2019-04-05 15:26 ` Ranjani Sridharan
2019-03-28 13:41 ` [PATCH 4/4] soundwire: remove unused struct sdw_bus_conf definition Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e99ce6b-af40-df7b-9548-0055261c6440@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=sanyog.r.kale@intel.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.