From: Jan Beulich <jbeulich@suse.com>
To: Julien Grall <julien@xen.org>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
George Dunlap <george.dunlap@citrix.com>,
Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
Henry Wang <Henry.Wang@arm.com>,
Michal Orzel <michal.orzel@amd.com>,
Manuel Bouyer <bouyer@antioche.eu.org>
Subject: Re: [PATCH] console: make input work again for pv-shim
Date: Thu, 19 Oct 2023 08:35:28 +0200 [thread overview]
Message-ID: <0f6a604e-7201-ea2d-cea3-89a3b9b08919@suse.com> (raw)
In-Reply-To: <f2b51b47-fdeb-45a6-92c7-5b21da1855fe@xen.org>
On 18.10.2023 20:00, Julien Grall wrote:
> On 18/10/2023 15:58, Jan Beulich wrote:
>> From: Manuel Bouyer <bouyer@antioche.eu.org>
>>
>> The use of rcu_lock_domain_by_id() right in switch_serial_input() makes
>> assumptions about domain IDs which don't hold when in shim mode: The
>> sole (initial) domain there has a non-zero ID. Obtain the real domain ID
>> in that case (generalized as get_initial_domain_id() returns zero when
>> not in shim mode).
>>
>> Note that console_input_domain() isn't altered, for not being used when
>> in shim mode (or more generally on x86).
>
> I think it would be worth to either add a comment in
> console_input_domain() and/or #ifdef the code. In any case...
I have such a patch already, but intend to submit only for post-4.18.
>> Fixes: c2581c58bec9 ("xen/console: skip switching serial input to non existing domains")
>> Signed-off-by: Manuel Bouyer <bouyer@antioche.eu.org>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> ...
>
> Reviewed-by: Julien Grall <jgrall@amazon.com>
Thanks.
> Also, should we consider it for xen 4.18? (I notice there is no for-4.18
> tag).
Of course we should, as it's a regression. I probably should have added
the tag, despite my dislike for such. Intention was imo nevertheless
clear, by me having Cc-ed Henry.
Jan
next prev parent reply other threads:[~2023-10-19 6:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 14:58 [PATCH] console: make input work again for pv-shim Jan Beulich
2023-10-18 18:00 ` Julien Grall
2023-10-19 0:29 ` Henry Wang
2023-10-19 6:35 ` Jan Beulich [this message]
2023-10-19 6:50 ` Henry Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f6a604e-7201-ea2d-cea3-89a3b9b08919@suse.com \
--to=jbeulich@suse.com \
--cc=Henry.Wang@arm.com \
--cc=andrew.cooper3@citrix.com \
--cc=bouyer@antioche.eu.org \
--cc=george.dunlap@citrix.com \
--cc=julien@xen.org \
--cc=michal.orzel@amd.com \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.