Re: [PATCH v2 08/12] hw: arm: allwinner-r40: Fix the mmc controller's type

From: qianfan <qianfanguijin@163.com>
To: Niek Linnenbank <nieklinnenbank@gmail.com>
Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org,
	"Strahinja Jankovic" <strahinja.p.jankovic@gmail.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Beniamino Galvani" <b.galvani@gmail.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: Re: [PATCH v2 08/12] hw: arm: allwinner-r40: Fix the mmc controller's type
Date: Tue, 18 Apr 2023 18:56:46 +0800	[thread overview]
Message-ID: <0f6e9f22-cc16-065f-976e-657359297928@163.com> (raw)
In-Reply-To: <CAPan3WrcM_tyfsVQNkZxtpj3pse6O58Nvkcwg7X=XHYt+seGgQ@mail.gmail.com>


在 2023/4/7 3:22, Niek Linnenbank 写道:
> Hi Qianfan Zhao,
>
> Is this change really needed as a separate patch?
> Looks like it would make sense just to squash it with the original 
> patch 01?
The class type of TYPE_AW_SDHOST_SUN50I_A64 was introduced when patch-07.
Add patch-01 doesn't has that class.

So this is following the previous patch.
>
> Regards,
> Niek
>
> On Tue, Mar 28, 2023 at 7:47 AM <qianfanguijin@163.com> wrote:
>
>     From: qianfan Zhao <qianfanguijin@163.com>
>
>     R40 has SAMP_DL_REG register and mmc2 controller has only 8K dma
>     buffer.
>     Fix it's compatible string.
>
>     Signed-off-by: qianfan Zhao <qianfanguijin@163.com>
>     ---
>      hw/arm/allwinner-r40.c | 2 +-
>      1 file changed, 1 insertion(+), 1 deletion(-)
>
>     diff --git a/hw/arm/allwinner-r40.c b/hw/arm/allwinner-r40.c
>     index 0e4542d35f..b148c56449 100644
>     --- a/hw/arm/allwinner-r40.c
>     +++ b/hw/arm/allwinner-r40.c
>     @@ -271,7 +271,7 @@ static void allwinner_r40_init(Object *obj)
>
>          for (int i = 0; i < AW_R40_NUM_MMCS; i++) {
>              object_initialize_child(obj, mmc_names[i], &s->mmc[i],
>     -                                TYPE_AW_SDHOST_SUN5I);
>     +                                TYPE_AW_SDHOST_SUN50I_A64);
>          }
>
>          object_initialize_child(obj, "twi0", &s->i2c0,
>     TYPE_AW_I2C_SUN6I);
>     -- 
>     2.25.1
>
>
>
> -- 
> Niek Linnenbank
>