From: schowdhu@codeaurora.org
To: Vinod Koul <vkoul@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org,
Rajendra Nayak <rnayak@codeaurora.org>,
Sibi Sankar <sibis@codeaurora.org>,
Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
Subject: Re: [PATCH V0 2/6] arm64: dts: qcom: sm8150: Add Data Capture and Compare(DCC) support node
Date: Wed, 17 Feb 2021 18:40:22 +0530 [thread overview]
Message-ID: <10001950e73eb5e322fda6359103ebda@codeaurora.org> (raw)
In-Reply-To: <20210217110331.GS2774@vkoul-mobl.Dlink>
Hi,
Please find the replies inline.
On 2021-02-17 16:33, Vinod Koul wrote:
> On 17-02-21, 12:18, Souradeep Chowdhury wrote:
>> Add the DCC(Data Capture and Compare) device tree node entry along
>> with
>> the addresses for register regions.
>
> This should be last patch..
Ack
>
>>
>> Signed-off-by: Souradeep Chowdhury <schowdhu@codeaurora.org>
>> ---
>> arch/arm64/boot/dts/qcom/sm8150.dtsi | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi
>> b/arch/arm64/boot/dts/qcom/sm8150.dtsi
>> index e5bb17b..3198bd3 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
>> @@ -654,6 +654,13 @@
>> interrupts = <GIC_SPI 582 IRQ_TYPE_LEVEL_HIGH>;
>> };
>>
>> + dcc@010a2000{
>
> no leading zero here and space before {
Ack
>
>> + compatible = "qcom,sm8150-dcc", "qcom,dcc";
>> + reg = <0x0 0x010a2000 0x0 0x1000>,
>> + <0x0 0x010ad000 0x0 0x3000>;
>
> pls align this to preceding line
Ack
>
>> + reg-names = "dcc-base", "dcc-ram-base";
>> + };
>> +
>> ufs_mem_hc: ufshc@1d84000 {
>> compatible = "qcom,sm8150-ufshc", "qcom,ufshc",
>> "jedec,ufs-2.0";
>> --
>> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
>> member
>> of Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2021-02-17 13:11 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-17 6:48 [PATCH V0 0/6] Add driver support for Data Capture and Compare Engine(DCC) for SM8150 Souradeep Chowdhury
2021-02-17 6:48 ` [PATCH V0 1/6] dt-bindings: Added the yaml bindings for DCC Souradeep Chowdhury
2021-02-17 11:02 ` Vinod Koul
2021-02-17 11:02 ` Vinod Koul
2021-02-17 13:20 ` schowdhu
2021-02-17 20:24 ` Rob Herring
2021-02-17 20:24 ` Rob Herring
2021-02-17 6:48 ` [PATCH V0 2/6] arm64: dts: qcom: sm8150: Add Data Capture and Compare(DCC) support node Souradeep Chowdhury
2021-02-17 11:03 ` Vinod Koul
2021-02-17 11:03 ` Vinod Koul
2021-02-17 13:10 ` schowdhu [this message]
2021-02-17 6:48 ` [PATCH V0 3/6] soc: qcom: dcc:Add driver support for Data Capture and Compare unit(DCC) Souradeep Chowdhury
2021-02-17 8:08 ` kernel test robot
2021-02-17 8:08 ` kernel test robot
2021-02-17 8:08 ` kernel test robot
2021-02-18 6:59 ` Vinod Koul
2021-02-18 6:59 ` Vinod Koul
2021-02-18 11:51 ` schowdhu
2021-02-17 6:48 ` [PATCH V0 4/6] soc: qcom: dcc:Add the sysfs variables to the Data Capture and Compare driver(DCC) Souradeep Chowdhury
2021-02-17 6:48 ` [PATCH V0 5/6] DCC:Added the sysfs entries for DCC(Data Capture and Compare) driver Souradeep Chowdhury
2021-02-17 6:48 ` [PATCH V0 6/6] MAINTAINERS:Added the entry for DCC(Data Capture and Compare) driver support Souradeep Chowdhury
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10001950e73eb5e322fda6359103ebda@codeaurora.org \
--to=schowdhu@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=saiprakash.ranjan@codeaurora.org \
--cc=sibis@codeaurora.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.