Re: [poky] [PATCH 0/3] lighttpd-1.4.72

From: Ross Burton <Ross.Burton@arm.com>
To: "gs-yoctoproject.org@gluelogic.com" <gs-yoctoproject.org@gluelogic.com>
Cc: "poky@lists.yoctoproject.org" <poky@lists.yoctoproject.org>
Subject: Re: [poky] [PATCH 0/3] lighttpd-1.4.72
Date: Fri, 20 Oct 2023 13:55:50 +0000	[thread overview]
Message-ID: <10278B77-7E5C-43FB-94CC-A1E7E0C50B95@arm.com> (raw)
In-Reply-To: <ZTJ4lpMInFmxKpVx@xps13>

On 20 Oct 2023, at 13:54, gs-yoctoproject.org@gluelogic.com wrote:
> 
> On Fri, Oct 20, 2023 at 12:18:22PM +0000, Ross Burton wrote:
>> On 20 Oct 2023, at 12:48, Glenn Strauss via lists.yoctoproject.org <gs-yoctoproject.org=gluelogic.com@lists.yoctoproject.org> wrote:
>>> Glenn Strauss (3):
>>> lighttpd: upgrade 1.4.71 -> 1.4.72
>>> lighttpd: update init script
>>> lighttpd: modernize lighttpd.conf
>> 
>> Poky is a generated repository that doesn’t actually have any patches directly merged into it, so these should be sent to openembedded-core@lists.yoctoproject.org <mailto:openembedded-core@lists.yoctoproject.org>.
> 
> I'll re-send to the openembedded-core list.
> Thanks for the pointer, Richard and Ross.
> 
> ==> Would someone please update the documentation?
> 
> https://docs.yoctoproject.org/contributor-guide/submit-changes.html#finding-a-suitable-mailing-list
> 4.4.3 Finding a Suitable Mailing List
> “meta-*” trees: These trees contain Metadata. Use the poky mailing list.

So we obviously need to make that list a bit clearer.  The relevant line was two above:

    • Core Metadata: Send your patches to the openembedded-core mailing list. For example, a change to anything under the meta or scripts directories should be sent to this mailing list.

A better way to do that would be to just list the top level folders, I’ll send a change.

>> However, I was also just looking at the lighttpd recipe.  Specifically I was extracting the sample site from the main package so it’s easier to add in your own site files, basically putting /var/www/pages into lighttpd-site-sample and then recommending that from the main package.  The goal being that in the simple test case the sample site is pulled in, but it’s trivial to package up your own site that conflicts with site-sample.
> 
> That sounds reasonable to me.
> I like the idea of being able to remove the sample site.
> I also like the idea of having a sample site to get people started.
> 
>> This worked but then I realised that the config file is fairly tied to the site too.  As - presumably - a lighttpd user, do you have any opinion on where the lighttpd.conf file should be packaged?  I’m leaning towards bundling it with the sample-site but am undecided as to whether that’s actually a good idea.
> 
> I am a lighttpd developer.  While I have some strong opinions about
> packages and how it is done in many different distros, I am less
> familiar with yocto specifics and more interested in trying to help
> people run the best available version of lighttpd, which is always
> the latest stable release.
> 
> I'll share my thoughts and hope some people using lighttpd with ptxdist
> can add their opinions, too.
> 
> Overall, one-size fits all packaging generally makes tradeoffs
> for new users, versus scripters, versus dev-ops.  Personally, I
> think packagers tend to overcomplicate things trying to please too
> many different user types at once.
> 
> The smallest lighttpd config is one line:
>  server.document-root = "/path/to/test/site"
> and lighttpd will by default listen on port 80 and will run as the user
> that started lighttpd.  Often, a test site also includes a second line
> in the config:
>  index-file.names = ("index.html")
> and the test site has a single file /path/to/test/site/index.html
> 
> I think that is what distros should ship, along with one more line:
>  include "/etc/lighttpd/conf.d/*.conf"
> 
> Users can then reconfigure the server as they like by dropping files in
> /etc/lighttpd/conf.d/*.conf, including overwriting the default document
> root with
>  server.document-root := "/path/to/default/site"
> and disabling index files with
>  index-file.names = ()
> or reconfiguring with something like
>  index-file.names := ("index.html", "index.htm")
> 
> The sample site, if a separate package, could add files into
> /etc/lighttpd/conf.d/*.conf (or whatever location ptxdist uses)
> with the sample site config.

That’s interesting, thanks.  Our use-case is slightly different in that we encourage people to customise the recipes as needed, whereas on Debian you wouldn’t expect to rebuild lighttpd at all.

A minimal lighttpd.conf which supports fragments sounds ideal.  Would it be sensible to have a truly minimal /etc/lightttd/lighttp.conf in the lighttpd package which sets just document.root/index-file-names, and then move the modernised config file you sent to /etc/lighttpd/conf.d/sample-site.conf as an example?

As a distro maintainer it’s hard to know enough about every package, so it’s good to have an upstream developer to ask questions!

Cheers,
Ross