Re: [PATCH] RDMA/hfi1: fix potential memory leak in setup_base_ctxt()

From: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
To: Jianglei Nie <niejianglei2021@163.com>, jgg@ziepe.ca, leon@kernel.org
Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] RDMA/hfi1: fix potential memory leak in setup_base_ctxt()
Date: Mon, 11 Jul 2022 07:52:25 -0400	[thread overview]
Message-ID: <1038e814-5f0d-17a3-1331-8ed24a64d597@cornelisnetworks.com> (raw)
In-Reply-To: <20220711070718.2318320-1-niejianglei2021@163.com>

On 7/11/22 3:07 AM, Jianglei Nie wrote:
> setup_base_ctxt() allocates a memory chunk for uctxt->groups with
> hfi1_alloc_ctxt_rcv_groups(). When init_user_ctxt() fails, uctxt->groups
> is not released, which will lead to a memory leak.
> 
> We should release the uctxt->groups with hfi1_free_ctxt_rcv_groups()
> when init_user_ctxt() fails.
> 
> Signed-off-by: Jianglei Nie <niejianglei2021@163.com>
> ---
>  drivers/infiniband/hw/hfi1/file_ops.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/hw/hfi1/file_ops.c b/drivers/infiniband/hw/hfi1/file_ops.c
> index 2e4cf2b11653..629beff053ad 100644
> --- a/drivers/infiniband/hw/hfi1/file_ops.c
> +++ b/drivers/infiniband/hw/hfi1/file_ops.c
> @@ -1179,8 +1179,10 @@ static int setup_base_ctxt(struct hfi1_filedata *fd,
>  		goto done;
>  
>  	ret = init_user_ctxt(fd, uctxt);
> -	if (ret)
> +	if (ret) {
> +		hfi1_free_ctxt_rcv_groups(uctxt);
>  		goto done;
> +	}
>  
>  	user_init(uctxt);
>  

Doesn't seem like this patch is correct. The free is done when the file is
closed, along with other clean up stuff. See hfi1_file_close().

-Denny