Re: [PATCH] Input: aiptek: fix crash on detecting device without endpoints

From: Vladis Dronov <vdronov@redhat.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH] Input: aiptek: fix crash on detecting device without endpoints
Date: Wed, 2 Dec 2015 06:03:07 -0500 (EST)	[thread overview]
Message-ID: <1052675973.31763834.1449054187055.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20151201211614.GB3740@dtor-ws>

Hello, Dmitry,

> > +	if (intf->altsetting[0].desc.bNumEndpoints < 1) {
> > +		dev_warn(&intf->dev,
>
> This should be dev_err as we are aborting device initialization. I know
> the driver user warn/info in similar places, but it is not right, we
> might want to adjust it at some point.

Yes, the driver using dev_warn() in all the similar error paths was a
reason for me to use dev_warn() here.

> > +		err = -ENODEV;
>
> I believe it should be -EINVAL as well. I adjusted the above 3 items
> and applied.

Indeed, this suits best. Thank you for handling this and the issue in
general.

Best regards,
Vladis Dronov | Red Hat, Inc. | Product Security Engineer