From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Abel Vesa <abel.vesa@linaro.org>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Mike Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-clk@vger.kernel.org
Subject: Re: [PATCH v2 1/9] dt-bindings: clock: Add SM8550 GCC clocks
Date: Thu, 24 Nov 2022 12:48:18 +0100 [thread overview]
Message-ID: <1078fdea-bbb4-2a07-85f9-a81bc876dcbe@linaro.org> (raw)
In-Reply-To: <20221123142009.594781-2-abel.vesa@linaro.org>
On 23/11/2022 15:20, Abel Vesa wrote:
> Add device tree bindings for global clock controller on SM8550 SoCs.
>
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---
>
> Changes since v1:
> * dropped clock-names since driver uses IDs now
> * based on recent bindings, like Krzysztof asked
> * used qcom,gcc.yaml and dropped redundant properties
> * renamed qcom,gcc-sm8550.h to qcom,sm8550-gcc.h, to match
> compatible
> * dropped "Optional", like Krzysztof asked
>
> .../bindings/clock/qcom,sm8550-gcc.yaml | 56 +++++
> include/dt-bindings/clock/qcom,sm8550-gcc.h | 231 ++++++++++++++++++
> 2 files changed, 287 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/clock/qcom,sm8550-gcc.yaml
> create mode 100644 include/dt-bindings/clock/qcom,sm8550-gcc.h
>
> diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8550-gcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8550-gcc.yaml
> new file mode 100644
> index 000000000000..acc540aa137d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/qcom,sm8550-gcc.yaml
> @@ -0,0 +1,56 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/qcom,sm8550-gcc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm Global Clock & Reset Controller on SM8550
> +
> +maintainers:
> + - Bjorn Andersson <andersson@kernel.org>
> +
> +description: |
> + Qualcomm global clock control module provides the clocks, resets and power
> + domains on SM8550
> +
> + See also:: include/dt-bindings/clock/qcom,sm8550-gcc.h
> +
> +properties:
> + compatible:
> + const: qcom,sm8550-gcc
> +
> + clocks:
> + items:
> + - description: Board XO source
> + - description: Sleep clock source
> + - description: PCIE 0 Pipe clock source
> + - description: PCIE 1 Pipe clock source
> + - description: PCIE 1 Phy Auxiliary clock source
> + - description: UFS Phy Rx symbol 0 clock source
> + - description: UFS Phy Rx symbol 1 clock source
> + - description: UFS Phy Tx symbol 0 clock source
> + - description: USB3 Phy wrapper pipe clock source
> + minItems: 2
I didn't mention in your v1 this explicitly (although I asked Melody to
drop it), so apologies for this. Based on my understand and our IRC
discussion, these clocks are needed for the driver (even if optional in
some states of hardware). If driver needs them, let's make them
required, so please drop "minItems: 2".
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-11-24 11:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-23 14:20 [PATCH v2 0/9] clk: qcom: Add support for SM8550 Abel Vesa
2022-11-23 14:20 ` [PATCH v2 1/9] dt-bindings: clock: Add SM8550 GCC clocks Abel Vesa
2022-11-24 11:48 ` Krzysztof Kozlowski [this message]
2022-11-23 14:20 ` [PATCH v2 2/9] dt-bindings: clock: Add SM8550 TCSR CC clocks Abel Vesa
2022-11-23 21:17 ` Rob Herring
2022-11-24 11:51 ` Krzysztof Kozlowski
2022-11-23 14:20 ` [PATCH v2 3/9] clk: qcom: gdsc: Add configurable poll timeout Abel Vesa
2022-11-23 14:20 ` [PATCH v2 4/9] clk: qcom: Add LUCID_OLE PLL type for SM8550 Abel Vesa
2022-11-23 14:20 ` [PATCH v2 5/9] clk: qcom: Add clock driver " Abel Vesa
2022-11-23 16:10 ` Konrad Dybcio
2022-11-23 16:11 ` Konrad Dybcio
2022-11-23 14:20 ` [PATCH v2 6/9] dt-bindings: clock: Add RPMHCC " Abel Vesa
2022-11-23 14:20 ` [PATCH v2 7/9] dt-bindings: clock: qcom,rpmh: Add CXO PAD clock IDs Abel Vesa
2022-11-23 14:20 ` [PATCH v2 8/9] clk: qcom: rpmh: Add support for SM8550 rpmh clocks Abel Vesa
2022-11-23 16:12 ` Konrad Dybcio
2022-11-23 14:20 ` [PATCH v2 9/9] clk: qcom: Add TCSR clock driver for SM8550 Abel Vesa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1078fdea-bbb4-2a07-85f9-a81bc876dcbe@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=abel.vesa@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.