From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Warner Losh <imp@bsdimp.com>, qemu-devel@nongnu.org
Cc: Kyle Evans <kevans@freebsd.org>, richard.henderson@linaro.org
Subject: Re: [PATCH 04/14] bsd-user: export get_errno and is_error from syscall.c
Date: Sat, 25 Sep 2021 12:33:43 +0200 [thread overview]
Message-ID: <10bb09fe-8995-29ab-e719-616d1a7e6114@amsat.org> (raw)
In-Reply-To: <20210922061438.27645-5-imp@bsdimp.com>
On 9/22/21 08:14, Warner Losh wrote:
> Make get_errno and is_error global so files other than syscall.c can use
> them.
>
> Signed-off-by: Warner Losh <imp@bsdimp.com>
> ---
> bsd-user/qemu.h | 4 ++++
> bsd-user/syscall.c | 10 +++++-----
> 2 files changed, 9 insertions(+), 5 deletions(-)
>
> diff --git a/bsd-user/qemu.h b/bsd-user/qemu.h
> index 522d6c4031..22fc3a6c30 100644
> --- a/bsd-user/qemu.h
> +++ b/bsd-user/qemu.h
> @@ -235,6 +235,10 @@ extern unsigned long target_dflssiz;
> extern unsigned long target_maxssiz;
> extern unsigned long target_sgrowsiz;
>
> +/* syscall.c */
> +abi_long get_errno(abi_long ret);
> +int is_error(abi_long ret);
> +
> /* user access */
>
> #define VERIFY_READ PAGE_READ
> diff --git a/bsd-user/syscall.c b/bsd-user/syscall.c
> index 372836d44d..a579d52ede 100644
> --- a/bsd-user/syscall.c
> +++ b/bsd-user/syscall.c
> @@ -33,18 +33,18 @@
> static abi_ulong target_brk;
> static abi_ulong target_original_brk;
>
> -static inline abi_long get_errno(abi_long ret)
> +abi_long get_errno(abi_long ret)
> {
> - if (ret == -1)
> + if (ret == -1) {
> /* XXX need to translate host -> target errnos here */
> return -(errno);
> - else
> - return ret;
> + }
> + return ret;
> }
>
> #define target_to_host_bitmask(x, tbl) (x)
>
> -static inline int is_error(abi_long ret)
> +int is_error(abi_long ret)
Since you are modifying this, do you mind having it return
a boolean type instead?
> {
> return (abi_ulong)ret >= (abi_ulong)(-4096);
> }
>
Preferably having is_error() returning bool:
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
next prev parent reply other threads:[~2021-09-25 10:34 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-22 6:14 [PATCH 00/14] bsd-user: misc cleanup for aarch64 import Warner Losh
2021-09-22 6:14 ` [PATCH 01/14] bsd-user/target_os-user.h: Remove support for FreeBSD older than 12.0 Warner Losh
2021-09-22 6:14 ` [PATCH 02/14] bsd-user/strace.list: Remove support for FreeBSD versions " Warner Losh
2021-09-23 17:57 ` Richard Henderson
2021-09-22 6:14 ` [PATCH 03/14] bsd-user: TARGET_RESET define is unused, remove it Warner Losh
2021-09-23 17:57 ` Richard Henderson
2021-09-25 10:30 ` Philippe Mathieu-Daudé
2021-09-22 6:14 ` [PATCH 04/14] bsd-user: export get_errno and is_error from syscall.c Warner Losh
2021-09-23 17:58 ` Richard Henderson
2021-09-25 10:33 ` Philippe Mathieu-Daudé [this message]
2021-09-26 17:14 ` Warner Losh
2021-09-22 6:14 ` [PATCH 05/14] bsd-user/errno_defs.h: Add internal error numbers Warner Losh
2021-09-23 17:59 ` Richard Henderson
2021-09-22 6:14 ` [PATCH 06/14] bsd-user: move TARGET_MC_GET_CLEAR_RET to target_os_signal.h Warner Losh
2021-09-23 18:00 ` Richard Henderson
2021-09-25 10:35 ` Philippe Mathieu-Daudé
2021-09-26 17:16 ` Warner Losh
2021-09-22 6:14 ` [PATCH 07/14] bsd-user/target_os_elf.h: Remove fallback ELF_HWCAP and reorder Warner Losh
2021-09-23 18:01 ` Richard Henderson
2021-09-25 10:36 ` Philippe Mathieu-Daudé
2021-09-22 6:14 ` [PATCH 08/14] bsd-user/target_os_elf: If ELF_HWCAP2 is defined, publish it Warner Losh
2021-09-23 18:01 ` Richard Henderson
2021-09-25 10:37 ` Philippe Mathieu-Daudé
2021-09-22 6:14 ` [PATCH 09/14] bsd-user: Remove used from TaskState Warner Losh
2021-09-23 18:02 ` Richard Henderson
2021-09-25 10:38 ` Philippe Mathieu-Daudé
2021-09-22 6:14 ` [PATCH 10/14] bsd-user: Add stop_all_tasks Warner Losh
2021-09-23 18:04 ` Richard Henderson
2021-09-22 6:14 ` [PATCH 11/14] bsd-user/sysarch: Move to using do_freebsd_arch_sysarch interface Warner Losh
2021-09-23 18:07 ` Richard Henderson
2021-09-24 15:25 ` Warner Losh
2021-09-22 6:14 ` [PATCH 12/14] bsd-user/sysarch: Provide a per-arch framework for sysarch syscall Warner Losh
2021-09-23 18:08 ` Richard Henderson
2021-09-25 10:46 ` Philippe Mathieu-Daudé
2021-09-26 17:21 ` Warner Losh
2021-09-22 6:14 ` [PATCH 13/14] bsd-user: Rename sigqueue to qemu_sigqueue Warner Losh
2021-09-23 18:09 ` Richard Henderson
2021-09-25 10:46 ` Philippe Mathieu-Daudé
2021-09-22 6:14 ` [PATCH 14/14] bsd-user/signal: Create a dummy signal queueing function Warner Losh
2021-09-23 18:13 ` Richard Henderson
2021-09-24 20:11 ` Warner Losh
2021-09-24 20:30 ` Kyle Evans
2021-09-24 23:51 ` Richard Henderson
2021-09-26 18:14 ` Warner Losh
2021-09-26 18:34 ` Philippe Mathieu-Daudé
2021-09-26 19:00 ` Warner Losh
2021-09-26 19:13 ` Philippe Mathieu-Daudé
2021-09-25 10:50 ` Philippe Mathieu-Daudé
2021-09-25 14:53 ` Warner Losh
2021-09-26 3:06 ` Warner Losh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10bb09fe-8995-29ab-e719-616d1a7e6114@amsat.org \
--to=f4bug@amsat.org \
--cc=imp@bsdimp.com \
--cc=kevans@freebsd.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.