Re: [PATCH] platform/x86/amd/pmf: Add new ACPI ID AMDI0103

From: Hans de Goede <hdegoede@redhat.com>
To: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>, markgross@kernel.org
Cc: platform-driver-x86@vger.kernel.org, Patil.Reddy@amd.com,
	mario.limonciello@amd.com
Subject: Re: [PATCH] platform/x86/amd/pmf: Add new ACPI ID AMDI0103
Date: Wed, 12 Jul 2023 16:58:58 +0200	[thread overview]
Message-ID: <1122525e-1567-f7e1-cefc-dacd938220e3@redhat.com> (raw)
In-Reply-To: <20230711100903.384151-1-Shyam-sundar.S-k@amd.com>

Hi,

On 7/11/23 12:09, Shyam Sundar S K wrote:
> Add new ACPI ID AMDI0103 used by upcoming AMD platform to the PMF
> supported list of devices.
> 
> Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>

Thank you for your patch, I've applied this patch to my fixes
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=fixes

I have already included this patch in my first fixes pull-req to Linus
for the current kernel development cycle.

Regards,

Hans

> ---
>  drivers/platform/x86/amd/pmf/core.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/platform/x86/amd/pmf/core.c b/drivers/platform/x86/amd/pmf/core.c
> index d5bb775dadcf..730b22457117 100644
> --- a/drivers/platform/x86/amd/pmf/core.c
> +++ b/drivers/platform/x86/amd/pmf/core.c
> @@ -40,6 +40,7 @@
>  /* List of supported CPU ids */
>  #define AMD_CPU_ID_RMB			0x14b5
>  #define AMD_CPU_ID_PS			0x14e8
> +#define PCI_DEVICE_ID_AMD_1AH_M20H_ROOT	0x1507
>  
>  #define PMF_MSG_DELAY_MIN_US		50
>  #define RESPONSE_REGISTER_LOOP_MAX	20000
> @@ -242,6 +243,7 @@ int amd_pmf_send_cmd(struct amd_pmf_dev *dev, u8 message, bool get, u32 arg, u32
>  static const struct pci_device_id pmf_pci_ids[] = {
>  	{ PCI_DEVICE(PCI_VENDOR_ID_AMD, AMD_CPU_ID_RMB) },
>  	{ PCI_DEVICE(PCI_VENDOR_ID_AMD, AMD_CPU_ID_PS) },
> +	{ PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_1AH_M20H_ROOT) },
>  	{ }
>  };
>  
> @@ -312,6 +314,7 @@ static void amd_pmf_deinit_features(struct amd_pmf_dev *dev)
>  static const struct acpi_device_id amd_pmf_acpi_ids[] = {
>  	{"AMDI0100", 0x100},
>  	{"AMDI0102", 0},
> +	{"AMDI0103", 0},
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(acpi, amd_pmf_acpi_ids);