All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Gleb Natapov <gleb@kernel.org>, Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm <kvm@vger.kernel.org>, Arthur Chunqi Li <yzt356@gmail.com>
Subject: [PATCH 07/15] VMX: Remove unneeded basic_init
Date: Mon, 16 Dec 2013 10:57:20 +0100	[thread overview]
Message-ID: <1151d6ad66a10dade66732a6ec76fc19c5580fae.1387187847.git.jan.kiszka@siemens.com> (raw)
In-Reply-To: <cover.1387187847.git.jan.kiszka@siemens.com>
In-Reply-To: <cover.1387187847.git.jan.kiszka@siemens.com>

We already accept the init handler to be NULL if there is no need for
initialization.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 x86/vmx_tests.c | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/x86/vmx_tests.c b/x86/vmx_tests.c
index 74d633b..a25afdc 100644
--- a/x86/vmx_tests.c
+++ b/x86/vmx_tests.c
@@ -43,10 +43,6 @@ static inline u32 get_stage()
 	return s;
 }
 
-void basic_init()
-{
-}
-
 void basic_guest_main()
 {
 	/* Here is a basic guest_main, print Hello World */
@@ -1134,9 +1130,9 @@ static int ept_exit_handler()
 /* name/init/guest_main/exit_handler/syscall_handler/guest_regs
    basic_* just implement some basic functions */
 struct vmx_test vmx_tests[] = {
-	{ "null", basic_init, basic_guest_main, basic_exit_handler,
+	{ "null", NULL, basic_guest_main, basic_exit_handler,
 		basic_syscall_handler, {0} },
-	{ "vmenter", basic_init, vmenter_main, vmenter_exit_handler,
+	{ "vmenter", NULL, vmenter_main, vmenter_exit_handler,
 		basic_syscall_handler, {0} },
 	{ "preemption timer", preemption_timer_init, preemption_timer_main,
 		preemption_timer_exit_handler, basic_syscall_handler, {0} },
@@ -1144,7 +1140,7 @@ struct vmx_test vmx_tests[] = {
 		test_ctrl_pat_exit_handler, basic_syscall_handler, {0} },
 	{ "control field EFER", test_ctrl_efer_init, test_ctrl_efer_main,
 		test_ctrl_efer_exit_handler, basic_syscall_handler, {0} },
-	{ "CR shadowing", basic_init, cr_shadowing_main,
+	{ "CR shadowing", NULL, cr_shadowing_main,
 		cr_shadowing_exit_handler, basic_syscall_handler, {0} },
 	{ "I/O bitmap", iobmp_init, iobmp_main, iobmp_exit_handler,
 		basic_syscall_handler, {0} },
-- 
1.8.1.1.298.ge7eed54


  parent reply	other threads:[~2013-12-16  9:57 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-16  9:57 [PATCH 00/15] kvm-unit-tests: Fix and enhance nVMX tests Jan Kiszka
2013-12-16  9:57 ` [PATCH 01/15] VMX: Fix initialization of GDT, IDT and TR descriptors Jan Kiszka
2013-12-16  9:57 ` [PATCH 02/15] VMX: Drop redundant return statements Jan Kiszka
2013-12-16  9:57 ` [PATCH 03/15] rmap_chain: Remove dead code Jan Kiszka
2013-12-16  9:57 ` [PATCH 04/15] emulator: Exclude test_lgdt_lidt from building Jan Kiszka
2013-12-17 10:31   ` Paolo Bonzini
2013-12-16  9:57 ` [PATCH 05/15] init: Fix warning about returning without code Jan Kiszka
2013-12-16  9:57 ` [PATCH 06/15] lib/x86/smp: Fix compiler warnings Jan Kiszka
2013-12-17 10:33   ` Paolo Bonzini
2013-12-17 10:35   ` Paolo Bonzini
2013-12-17 11:17     ` [PATCH v2 " Jan Kiszka
2013-12-16  9:57 ` Jan Kiszka [this message]
2013-12-16  9:57 ` [PATCH 08/15] VMX: Fix capability check for EPT test Jan Kiszka
2013-12-16  9:57 ` [PATCH 09/15] VMX: Let init handler decide about test start Jan Kiszka
2013-12-16  9:57 ` [PATCH 10/15] VMX: Remove unused return code from setup_ept_range Jan Kiszka
2013-12-16  9:57 ` [PATCH 11/15] VMX: Make syscall handler optional Jan Kiszka
2013-12-16  9:57 ` [PATCH 12/15] VMX: Simplify basic handlers Jan Kiszka
2013-12-16  9:57 ` [PATCH 13/15] VMX: Rework and enhance initial feature detection/enabling Jan Kiszka
2013-12-16  9:57 ` [PATCH 14/15] VMX: Add test cases around interrupt injection and halting Jan Kiszka
2014-03-25 11:18   ` Paolo Bonzini
2014-03-25 12:05     ` Jan Kiszka
2013-12-16  9:57 ` [PATCH 15/15] VMX: Add test case for preemption timer firing during hlt Jan Kiszka
2013-12-18  9:36 ` [PATCH 00/15] kvm-unit-tests: Fix and enhance nVMX tests Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1151d6ad66a10dade66732a6ec76fc19c5580fae.1387187847.git.jan.kiszka@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=gleb@kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=yzt356@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.