From: Bart Van Assche <bvanassche@acm.org>
To: Josef Bacik <josef@toxicpanda.com>,
linux-block@vger.kernel.org, kernel-team@fb.com, osandov@fb.com
Subject: Re: [PATCH 1/3] blktests: add cgroup2 infrastructure
Date: Tue, 1 Jan 2019 19:13:06 -0800 [thread overview]
Message-ID: <1211bf78-c442-ea71-9e71-f6d86681ed56@acm.org> (raw)
In-Reply-To: <20181204174733.7423-2-josef@toxicpanda.com>
On 12/4/18 9:47 AM, Josef Bacik wrote:
> In order to test io.latency and other cgroup related things we need some
> supporting helpers to setup and tear down cgroup2. This adds support
> for checking that we can even configure cgroup2 things, set them up if
> need be, and then add the cleanup stuff to the main cleanup function so
> everything is always in a clean state.
Is this the patch that went in as commit ae7daae7e35a ("blktests: add
cgroup2 infrastructure")? I think that commit introduced a regression.
With that patch applied the SRP tests fail as follows:
# ./check -q srp/001
srp/001 (Create and remove LUNs)
runtime 4.067s ...
common/cgroup: line 25: CGROUP2_DIR: unbound variable
Is this a known issue?
Bart.
next prev parent reply other threads:[~2019-01-02 3:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-04 17:47 [PATCH 0/3] io.latency test for blktests Josef Bacik
2018-12-04 17:47 ` [PATCH 1/3] blktests: add cgroup2 infrastructure Josef Bacik
2019-01-02 3:13 ` Bart Van Assche [this message]
2019-01-15 16:40 ` Bart Van Assche
2019-01-17 1:40 ` Omar Sandoval
2019-01-17 2:31 ` Bart Van Assche
2019-01-17 14:59 ` Josef Bacik
2018-12-04 17:47 ` [PATCH 2/3] blktests: add python scripts for parsing fio json output Josef Bacik
2018-12-04 22:28 ` Federico Motta
2018-12-05 9:20 ` Johannes Thumshirn
2018-12-04 17:47 ` [PATCH 3/3] blktests: block/025: an io.latency test Josef Bacik
2018-12-04 22:27 ` Federico Motta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1211bf78-c442-ea71-9e71-f6d86681ed56@acm.org \
--to=bvanassche@acm.org \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=osandov@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.