From: Mark McLoughlin <markmc@redhat.com>
To: Alex Williamson <alex.williamson@hp.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>, kvm <kvm@vger.kernel.org>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH 1/4] virtio_net: Allow setting the MAC address of the NIC
Date: Wed, 14 Jan 2009 10:15:06 +0000 [thread overview]
Message-ID: <1231928106.4944.289.camel@localhost.localdomain> (raw)
In-Reply-To: <1231881796.9095.186.camel@bling>
On Tue, 2009-01-13 at 14:23 -0700, Alex Williamson wrote:
Commit log explaining why we need this.
> Signed-off-by: Alex Williamson <alex.williamson@hp.com>
Acked-by: Mark McLoughlin <markmc@redhat.com>
> + } else {
> random_ether_addr(dev->dev_addr);
> + vdev->config->set(vdev, offsetof(struct virtio_net_config, mac),
> + dev->dev_addr, dev->addr_len);
> + }
Please make sure you test this with a host which doesn't set a default
mac address, otherwise it's "untested buggy code" :-)
Cheers,
Mark.
next prev parent reply other threads:[~2009-01-14 10:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-13 21:23 [PATCH 1/4] virtio_net: Allow setting the MAC address of the NIC Alex Williamson
2009-01-14 10:15 ` Mark McLoughlin [this message]
2009-01-14 15:40 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1231928106.4944.289.camel@localhost.localdomain \
--to=markmc@redhat.com \
--cc=alex.williamson@hp.com \
--cc=kvm@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.