From: Felipe Contreras <felipe.contreras@gmail.com>
To: linux-omap <linux-omap@vger.kernel.org>
Cc: Ameya Palande <ameya.palande@nokia.com>,
Omar Ramirez Luna <omar.ramirez@ti.com>,
Felipe Contreras <felipe.contreras@gmail.com>
Subject: [PATCH 04/10] dsp-bridge: deh: improve logging stuff
Date: Tue, 23 Mar 2010 23:25:36 +0200 [thread overview]
Message-ID: <1269379542-11892-5-git-send-email-felipe.contreras@gmail.com> (raw)
In-Reply-To: <1269379542-11892-1-git-send-email-felipe.contreras@gmail.com>
Get rid of printk, use dev_foo, and prettify the output.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
drivers/dsp/bridge/wmd/ue_deh.c | 33 ++++++++++++---------------------
1 files changed, 12 insertions(+), 21 deletions(-)
diff --git a/drivers/dsp/bridge/wmd/ue_deh.c b/drivers/dsp/bridge/wmd/ue_deh.c
index fae036f..0c29442 100644
--- a/drivers/dsp/bridge/wmd/ue_deh.c
+++ b/drivers/dsp/bridge/wmd/ue_deh.c
@@ -182,9 +182,7 @@ void bridge_deh_notify(struct deh_mgr *hdeh_mgr, u32 ulEventMask, u32 dwErrInfo)
&resources);
if (MEM_IS_VALID_HANDLE(deh_mgr_obj, SIGNATURE)) {
- printk(KERN_INFO
- "bridge_deh_notify: ********** DEVICE EXCEPTION "
- "**********\n");
+ dev_info(bridge, "%s: device exception\n", __func__);
dev_context =
(struct wmd_dev_context *)deh_mgr_obj->hwmd_context;
@@ -196,9 +194,8 @@ void bridge_deh_notify(struct deh_mgr *hdeh_mgr, u32 ulEventMask, u32 dwErrInfo)
deh_mgr_obj->err_info.dw_val2 = 0L;
deh_mgr_obj->err_info.dw_val3 = 0L;
deh_mgr_obj->err_info.dw_val1 = dwErrInfo;
- printk(KERN_ERR
- "bridge_deh_notify: DSP_SYSERROR, err_info "
- "= 0x%x\n", dwErrInfo);
+ dev_err(bridge, "%s: %s, err_info = 0x%x\n",
+ __func__, "DSP_SYSERROR", dwErrInfo);
break;
case DSP_MMUFAULT:
/*
@@ -206,18 +203,13 @@ void bridge_deh_notify(struct deh_mgr *hdeh_mgr, u32 ulEventMask, u32 dwErrInfo)
* structure.
*/
deh_mgr_obj->err_info.dw_err_mask = DSP_MMUFAULT;
- printk(KERN_INFO "bridge_deh_notify: DSP_MMUFAULT,"
- "err_info = 0x%x\n", dwErrInfo);
- printk(KERN_INFO
- "bridge_deh_notify: DSP_MMUFAULT, High "
- "Address = 0x%x\n",
- (unsigned int)deh_mgr_obj->err_info.dw_val1);
- printk(KERN_INFO "bridge_deh_notify: DSP_MMUFAULT, Low "
- "Address = 0x%x\n",
- (unsigned int)deh_mgr_obj->err_info.dw_val2);
- printk(KERN_INFO
- "bridge_deh_notify: DSP_MMUFAULT, fault "
- "address = 0x%x\n", (unsigned int)fault_addr);
+ dev_info(bridge, "%s: %s, err_info = 0x%x\n",
+ __func__, "DSP_MMUFAULT", dwErrInfo);
+ dev_info(bridge, "%s: %s, high=0x%x, low=0x%x, fault=0x%x\n",
+ __func__, "DSP_MMUFAULT",
+ (unsigned int) deh_mgr->err_info.dw_val1,
+ (unsigned int) deh_mgr->err_info.dw_val2,
+ (unsigned int) fault_addr);
dummy_va_addr =
(u32) mem_calloc(sizeof(char) * 0x1000, MEM_PAGED);
mem_physical =
@@ -257,9 +249,8 @@ void bridge_deh_notify(struct deh_mgr *hdeh_mgr, u32 ulEventMask, u32 dwErrInfo)
deh_mgr_obj->err_info.dw_val2 = 0L;
deh_mgr_obj->err_info.dw_val3 = 0L;
deh_mgr_obj->err_info.dw_val1 = dwErrInfo;
- printk(KERN_ERR
- "bridge_deh_notify: DSP_PWRERROR, err_info "
- "= 0x%x\n", dwErrInfo);
+ dev_err(bridge, "%s: %s, err_info = 0x%x\n",
+ __func__, "DSP_PWRERROR", dwErrInfo);
break;
#endif /* CONFIG_BRIDGE_NTFY_PWRERR */
default:
--
1.7.0.3
next prev parent reply other threads:[~2010-03-23 21:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-23 21:25 [PATCH 00/10] dsp-bridge: deh: general cleanups Felipe Contreras
2010-03-23 21:25 ` [PATCH 01/10] dsp-bridge: deh: remove obvious comments Felipe Contreras
2010-03-23 21:25 ` [PATCH 02/10] dsp-bridge: deh: trivial cleanups Felipe Contreras
2010-03-24 0:04 ` Omar Ramirez Luna
2010-03-23 21:25 ` [PATCH 03/10] dsp-bridge: deh: remove unnecessary casts Felipe Contreras
2010-03-23 21:25 ` Felipe Contreras [this message]
2010-03-23 21:25 ` [PATCH 05/10] dsp-bridge: deh: report mmu faults as errors Felipe Contreras
2010-03-23 21:25 ` [PATCH 06/10] dsp-bridge: deh: decrease nesting levels Felipe Contreras
2010-03-23 21:25 ` [PATCH 07/10] dsp-bridge: deh: fix obvious return codes Felipe Contreras
2010-03-23 21:25 ` [PATCH 08/10] dsp-bridge: deh: reorganize create() Felipe Contreras
2010-03-23 21:25 ` [PATCH 09/10] dsp-bridge: deh: fix hdeh_mgr silliness Felipe Contreras
2010-03-23 21:25 ` [PATCH 10/10] dsp-bridge: deh: fix dummy_va_addr Felipe Contreras
2010-04-15 12:12 ` [PATCH 00/10] dsp-bridge: deh: general cleanups Felipe Contreras
2010-04-19 20:37 ` Omar Ramirez Luna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1269379542-11892-5-git-send-email-felipe.contreras@gmail.com \
--to=felipe.contreras@gmail.com \
--cc=ameya.palande@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=omar.ramirez@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.