All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Clifton <pcjc2@cam.ac.uk>
To: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Subject: 8-bit vs. 10-bit palette mode, and LVDS dithering
Date: Sat, 24 Apr 2010 17:25:10 +0100	[thread overview]
Message-ID: <1272126310.5769.10.camel@pcjc2lap> (raw)

Hi guys,

I noticed an anomaly in the register settings on my GM45, according to
PIPEBCONF, it is set in 10-bit palette mode, yet the KMS code programs
the palette registers as if it is in 8-bit mode, and doesn't touch the
PIPEBGCMAX{RED,GREEN,BLUE} entries for the final interpolation step.

I've played with it, and I "think" my screen looks nicer with the
palette reset to 8-bit mode. The KMS driver never touches this register
normally, and I think it should reset it in intel_display.c's
intel_crtc_load_lut.

Ideally, it would be nice to have a higher resolution gamma correction.
Will it work if I drm_mode_crtc_set_gamma_size(&intel_crtc->base, 129);
and feed that into the 10-bit linear-interpolated lookup table?


At what stage is the LVDS dithering involved here.. gamma correction
probably makes a difference to whether a dither works nicely or not, and
I'm wondering whether I can tune the dithering process at all.

(I've got an HP laptop with a really bad colour profile, so it needs a
fair bit of correction to make colours appear properly. The hardware
hacker in me wonders if there is an EEPROM of gamma correction constants
on the panel which could be "fixed", but sadly litte data is available
from the panel manufacturer).

Regards,

-- 
Peter Clifton

Electrical Engineering Division,
Engineering Department,
University of Cambridge,
9, JJ Thomson Avenue,
Cambridge
CB3 0FA

Tel: +44 (0)7729 980173 - (No signal in the lab!)
Tel: +44 (0)1223 748328 - (Shared lab phone, ask for me)

             reply	other threads:[~2010-04-24 16:25 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-24 16:25 Peter Clifton [this message]
2010-04-26 14:29 ` 8-bit vs. 10-bit palette mode, and LVDS dithering Adam Jackson
2010-04-26 21:19   ` [PATCH] drm/intel: Set 8-bit gamma mode for the palette Peter Clifton
2010-04-27 13:53     ` Adam Jackson
2010-04-26 22:22   ` 8-bit vs. 10-bit palette mode, and LVDS dithering Peter Clifton
2010-04-26 22:24     ` [PATCH 1/3] drm/intel: Store full 16 bits of colors passed to gamma LUT Peter Clifton
2010-04-26 22:24     ` [PATCH 2/3] drm/intel: Attempt to use 10-bit gamma palette mode Peter Clifton
2010-04-27  1:09       ` Andrew Lutomirski
2010-04-27  6:44         ` Peter Clifton
2010-04-26 22:24     ` [PATCH 3/3] drm/intel: Use 10-bit palette properly, only store 129 entries Peter Clifton
2010-04-27 14:06       ` Adam Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1272126310.5769.10.camel@pcjc2lap \
    --to=pcjc2@cam.ac.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.