From: Namhyung Kim <namhyung@gmail.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: remove __phys_reloc_hide
Date: Mon, 09 Aug 2010 15:40:31 +0900 [thread overview]
Message-ID: <1281336031.976.11.camel@leonhard> (raw)
In-Reply-To: <87k4o08fv9.fsf@basil.nowhere.org>
2010-08-09 (월), 08:22 +0200, Andi Kleen:
> It's for the benefit of the compiler, we've had miscompilations
> due to undefined overflow for addresses in the past. The optimizer
> assumes this won't happen.
>
> Given the x86-64 version normally doesn't overflow, but it's
> still safer to have it.
>
> -Andi
>
Hi,
I'm not talking about the RELOC_HIDE itself. I do know we need it for
some specific case, ie. percpu. But in this case __pa_symbol(x) is
expanded to RELOC_HIDE((unsigned long)(x), 0) which does nothing
meaningful. I believe the overflow is not a concern here.
--
Regards,
Namhyung Kim
next prev parent reply other threads:[~2010-08-09 6:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-08 21:38 [PATCH] x86: remove __phys_reloc_hide Namhyung Kim
2010-08-09 6:22 ` Andi Kleen
2010-08-09 6:40 ` Namhyung Kim [this message]
2010-08-09 6:44 ` Andi Kleen
2010-08-09 7:04 ` Namhyung Kim
2010-08-09 7:22 ` Andi Kleen
2010-08-09 7:47 ` Namhyung Kim
2010-08-09 18:56 ` H. Peter Anvin
2010-08-10 7:05 ` Ingo Molnar
2010-08-10 10:46 ` Namhyung Kim
2010-08-11 5:44 ` Namhyung Kim
2010-08-11 19:09 ` H. Peter Anvin
2010-08-11 6:37 ` [PATCH] x86: add a comment to __pa_symbol Namhyung Kim
2010-08-11 7:44 ` [tip:x86/urgent] x86: Document __phys_reloc_hide() usage in __pa_symbol() tip-bot for Namhyung Kim
2018-06-19 23:00 ` [PATCH] x86: remove __phys_reloc_hide Thomas Gleixner
2010-08-09 8:07 ` Ingo Molnar
2010-08-09 18:56 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1281336031.976.11.camel@leonhard \
--to=namhyung@gmail.com \
--cc=andi@firstfloor.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.