From: Thomas Huth <thuth@redhat.com>
To: Daniel Henrique Barboza <danielhb413@gmail.com>, qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, clg@kaod.org, david@gibson.dropbear.id.au
Subject: Re: [PATCH 2/2] ivshmem-test.c: enable test_ivshmem_server for ppc64 arch
Date: Wed, 24 Nov 2021 08:35:31 +0100 [thread overview]
Message-ID: <129d4b5b-6118-239b-d1ed-c32f5193cc0f@redhat.com> (raw)
In-Reply-To: <20211123211932.284043-3-danielhb413@gmail.com>
On 23/11/2021 22.19, Daniel Henrique Barboza wrote:
> This test, if enabled by hand, was failing when the ivhsmem device was
> being declared as DEVICE_NATIVE_ENDIAN with the following error:
>
> /ppc64/ivshmem/pair: OK
> /ppc64/ivshmem/server:
> **
> ERROR:/home/danielhb/qemu/tests/qtest/ivshmem-test.c:367:test_ivshmem_server:
> assertion failed (ret != 0): (0 != 0)
> Aborted
>
> After the endianess change done in the previous patch, we can verify in
s/endianess/endianness/
> both a a Power 9 little-endian host and in a Power 8 big-endian host
> that this test is now passing:
>
> $ QTEST_QEMU_BINARY=./ppc64-softmmu/qemu-system-ppc64 ./tests/qtest/ivshmem-test -m slow
> /ppc64/ivshmem/single: OK
> /ppc64/ivshmem/hotplug: OK
> /ppc64/ivshmem/memdev: OK
> /ppc64/ivshmem/pair: OK
> /ppc64/ivshmem/server: OK
>
> Let's keep it that way by officialy enabling it for ppc64.
s/officialy/officially/
> Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
> ---
> tests/qtest/ivshmem-test.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/tests/qtest/ivshmem-test.c b/tests/qtest/ivshmem-test.c
> index dfa69424ed..fe94dd3b96 100644
> --- a/tests/qtest/ivshmem-test.c
> +++ b/tests/qtest/ivshmem-test.c
> @@ -463,7 +463,6 @@ static gchar *mktempshm(int size, int *fd)
> int main(int argc, char **argv)
> {
> int ret, fd;
> - const char *arch = qtest_get_arch();
> gchar dir[] = "/tmp/ivshmem-test.XXXXXX";
>
> g_test_init(&argc, &argv, NULL);
> @@ -488,9 +487,7 @@ int main(int argc, char **argv)
> qtest_add_func("/ivshmem/memdev", test_ivshmem_memdev);
> if (g_test_slow()) {
> qtest_add_func("/ivshmem/pair", test_ivshmem_pair);
> - if (strcmp(arch, "ppc64") != 0) {
> - qtest_add_func("/ivshmem/server", test_ivshmem_server);
> - }
> + qtest_add_func("/ivshmem/server", test_ivshmem_server);
> }
Acked-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2021-11-24 8:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-23 21:19 [PATCH 0/2] change IVSHMEM endianess to LITTLE_ENDIAN Daniel Henrique Barboza
2021-11-23 21:19 ` [PATCH 1/2] ivshmem.c: change endianness " Daniel Henrique Barboza
2021-11-23 21:19 ` [PATCH 2/2] ivshmem-test.c: enable test_ivshmem_server for ppc64 arch Daniel Henrique Barboza
2021-11-24 7:35 ` Thomas Huth [this message]
2021-11-23 23:22 ` [PATCH 0/2] change IVSHMEM endianess to LITTLE_ENDIAN Cédric Le Goater
2021-11-24 9:21 ` Daniel Henrique Barboza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=129d4b5b-6118-239b-d1ed-c32f5193cc0f@redhat.com \
--to=thuth@redhat.com \
--cc=clg@kaod.org \
--cc=danielhb413@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.