From: Konrad Dybcio <konrad.dybcio@somainline.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
Mark Brown <broonie@kernel.org>, Wolfram Sang <wsa@kernel.org>,
linux-arm-msm@vger.kernel.org, Andy Gross <agross@kernel.org>,
Matthias Kaehlcke <mka@chromium.org>,
Douglas Anderson <dianders@chromium.org>,
Sumit Semwal <sumit.semwal@linaro.org>,
Amit Pundir <amit.pundir@linaro.org>,
linux-spi@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 7/7] arm64: dts: qcom: sdm845: enable dma for spi
Date: Mon, 11 Jan 2021 21:45:03 +0100 [thread overview]
Message-ID: <12aae061-3a7e-883f-9b82-0b608ccf9441@somainline.org> (raw)
In-Reply-To: <20210111174649.GC2771@vkoul-mobl>
> If it is working without GPI enabled, it would work.. GPI for QUP is
> something that requires firmware and would have to be enabled by
> firmware
I think with the new code of yours:
mas->tx = dma_request_slave_channel(mas->dev, "tx");
+ if (IS_ERR_OR_NULL(mas->tx)) {
+ dev_err(mas->dev, "Failed to get tx DMA ch %ld", PTR_ERR(mas->tx)); ret = PTR_ERR(mas->tx); + goto out_pm;
it *may* fail to probe with the channels assigned in the "dmas=" property but with the engine having "status=disabled", but as I don't have any hardware to test that driver on, please confirm whether my concerns are right..
> Since DMA support may not be available on certain targets (firmware
> support), so enabling per board would make sense
Oh really, are there SDM845 boards shipping with GPI DMA *disabled to all peripherals*?
Konrad
next prev parent reply other threads:[~2021-01-11 20:46 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 15:16 [PATCH 0/7] Add and enable GPI DMA users Vinod Koul
2021-01-11 15:16 ` [PATCH 1/7] soc: qcom: geni: move GENI_IF_DISABLE_RO to common header Vinod Koul
2021-01-11 15:31 ` Bjorn Andersson
2021-01-11 15:16 ` [PATCH 2/7] soc: qcom: geni: move struct geni_wrapper to header Vinod Koul
2021-01-11 15:34 ` Bjorn Andersson
2021-01-11 17:43 ` Vinod Koul
2021-01-11 18:51 ` Bjorn Andersson
2021-01-11 15:16 ` [PATCH 3/7] soc: qcom: geni: Add support for gpi dma Vinod Koul
2021-01-11 15:40 ` Bjorn Andersson
2021-01-11 17:22 ` Vinod Koul
2021-01-13 0:01 ` Doug Anderson
2021-01-13 3:22 ` Vinod Koul
2021-01-11 15:16 ` [PATCH 4/7] spi: spi-geni-qcom: Add support for GPI dma Vinod Koul
2021-01-11 16:35 ` Mark Brown
2021-06-16 8:50 ` Vinod Koul
2021-06-16 11:35 ` Mark Brown
2021-06-16 12:02 ` Vinod Koul
2021-06-17 6:20 ` Vinod Koul
2021-01-11 17:19 ` Bjorn Andersson
2021-01-12 7:31 ` Lukas Wunner
2021-01-12 11:02 ` kernel test robot
2021-01-12 11:02 ` kernel test robot
2021-01-13 0:01 ` Doug Anderson
2021-01-13 3:24 ` Vinod Koul
2021-02-04 21:34 ` Dmitry Baryshkov
2021-01-11 15:16 ` [PATCH 5/7] i2c: qcom-geni: Add support for GPI DMA Vinod Koul
2021-01-11 18:14 ` Bjorn Andersson
2021-01-12 5:50 ` Vinod Koul
2021-01-11 15:16 ` [PATCH 6/7] arm64: dts: qcom: sdm845: Add gpi dma node Vinod Koul
2021-01-11 18:23 ` Bjorn Andersson
2021-01-12 4:21 ` Vinod Koul
2021-01-11 15:16 ` [PATCH 7/7] arm64: dts: qcom: sdm845: enable dma for spi Vinod Koul
2021-01-11 16:04 ` Konrad Dybcio
2021-01-11 17:46 ` Vinod Koul
2021-01-11 20:45 ` Konrad Dybcio [this message]
2021-01-12 4:19 ` Vinod Koul
2021-01-11 16:47 ` Doug Anderson
2021-01-11 17:56 ` Vinod Koul
2021-01-13 0:01 ` [PATCH 0/7] Add and enable GPI DMA users Doug Anderson
2021-01-13 3:03 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12aae061-3a7e-883f-9b82-0b608ccf9441@somainline.org \
--to=konrad.dybcio@somainline.org \
--cc=agross@kernel.org \
--cc=amit.pundir@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=dianders@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mka@chromium.org \
--cc=sumit.semwal@linaro.org \
--cc=vkoul@kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.