From: greearb@candelatech.com
To: linux-nfs@vger.kernel.org
Cc: Ben Greear <greearb@candelatech.com>
Subject: [RFC 01/11] sunrpc: Don't attempt to bind to AF_UNSPEC address.
Date: Thu, 9 Jun 2011 16:02:45 -0700 [thread overview]
Message-ID: <1307660575-6994-2-git-send-email-greearb@candelatech.com> (raw)
In-Reply-To: <1307660575-6994-1-git-send-email-greearb@candelatech.com>
From: Ben Greear <greearb@candelatech.com>
This lets calling code simply pass AF_UNSPEC addresses
instead of adding lots of checks to conditionally pass
NULL addresses.
Signed-off-by: Ben Greear <greearb@candelatech.com>
---
:100644 100644 72abb73... 37299c0... M net/sunrpc/xprtsock.c
net/sunrpc/xprtsock.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c
index 72abb73..37299c0 100644
--- a/net/sunrpc/xprtsock.c
+++ b/net/sunrpc/xprtsock.c
@@ -2509,9 +2509,9 @@ static struct rpc_xprt *xs_setup_xprt(struct xprt_create *args,
new = container_of(xprt, struct sock_xprt, xprt);
memcpy(&xprt->addr, args->dstaddr, args->addrlen);
xprt->addrlen = args->addrlen;
- if (args->srcaddr)
+ if (args->srcaddr && (args->srcaddr->sa_family != AF_UNSPEC)) {
memcpy(&new->srcaddr, args->srcaddr, args->addrlen);
- else {
+ } else {
int err;
err = xs_init_anyaddr(args->dstaddr->sa_family,
(struct sockaddr *)&new->srcaddr);
--
1.7.3.4
next prev parent reply other threads:[~2011-06-09 23:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-09 23:02 [RFC 00/11] NFS: Add client ability to bind to specific source-addr greearb
2011-06-09 23:02 ` greearb [this message]
2011-06-09 23:02 ` [RFC 02/11] nfs: Two AF_UNSPEC addresses should always match each other greearb
2011-06-09 23:02 ` [RFC 03/11] nfs: Add srcaddr member to nfs_client greearb
2011-06-09 23:02 ` [RFC 04/11] nfs: Use request destination addr as callback source addr greearb
2011-06-09 23:02 ` [RFC 05/11] nfs: Pay attention to srcaddr in v4.1 callback logic greearb
2011-06-09 23:02 ` [RFC 06/11] nfs: Use srcaddr in nfs_match_client greearb
2011-06-09 23:02 ` [RFC 07/11] nfs: Add srcaddr to /proc/fs/nfsfs/servers greearb
2011-06-09 23:02 ` [RFC 08/11] nfs: Pass srcaddr into mount request greearb
2011-06-09 23:02 ` [RFC 09/11] nfs: Propagate src-addr in client code greearb
2011-06-09 23:02 ` [RFC 10/11] nfs: Bind to srcaddr in rpcb_create greearb
2011-06-09 23:02 ` [RFC 11/11] nfs: Support srcaddr= to bind to specific IP address greearb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1307660575-6994-2-git-send-email-greearb@candelatech.com \
--to=greearb@candelatech.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.