From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Archit Taneja <archit@ti.com>
Cc: "Semwal, Sumit" <sumit.semwal@ti.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH 5/5] OMAP4: DSS2: VIDEO3 pipeline support
Date: Fri, 05 Aug 2011 12:26:36 +0300 [thread overview]
Message-ID: <1312536396.1907.37.camel@deskari> (raw)
In-Reply-To: <4E3BB603.7010908@ti.com>
On Fri, 2011-08-05 at 14:51 +0530, Archit Taneja wrote:
> Hi,
>
> On Friday 05 August 2011 02:13 PM, Semwal, Sumit wrote:
> >> On Fri, Aug 5, 2011 at 8:42 AM, Archit Taneja<archit@ti.com> wrote:
> >>>
> >>> Add support for VIDEO3 pipeline on OMAP4:
> >>> - Add VIDEO3 pipeline information in dss_features and omapdss.h
> >>> - Add VIDEO3 pipeline register coefficients in dispc.h
> >>> - Create a new overlay structure corresponding to VIDEO3.
> >>>
> >>> Signed-off-by: Archit Taneja<archit@ti.com>
> >>> ---
> > <snip>
> >>> - u32 fifo_size[3];
> >>> + u32 fifo_size[MAX_DSS_OVERLAYS];
> >>
> > Do you think it makes some sense in splitting the 'generalisation'
> > like this that you've done in the patch from the xxx_VIDEO3 changes?
>
> Yes, I could make a small patch which replaces "3" with
> MAX_DSS_OVERLAYS, and the patch which introduces VIDEO3 pipe will
> increase the macro value from 3 to 4.
While Sumit is right, I don't think that's worth the effort if it's just
about this single line.
I think this patch set looks fine. At least the register dump works just
the way I like it. I didn't test the vid3 yet, though.
Tomi
next prev parent reply other threads:[~2011-08-05 9:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-05 7:42 [PATCH 0/5] OMAP: DSS2: Miscellaneous DISPC Patches Archit Taneja
2011-08-05 7:42 ` [PATCH 1/5] OMAP: DSS2: DISPC: Prepare dispc_dump_regs() for shortening Archit Taneja
2011-08-05 7:42 ` [PATCH 2/5] OMAP: DSS2: DISPC: Shorten dispc_dump_regs() Archit Taneja
2011-08-05 7:42 ` [PATCH 3/5] OMAP: DSS2: DISPC: dispc_save_context() and dispc_restore_context() cleanup Archit Taneja
2011-08-05 7:42 ` [PATCH 4/5] OMAP: DSS2: DISPC: Shorten _dispc_set_color_conv_coef() Archit Taneja
2011-08-05 7:42 ` [PATCH 5/5] OMAP4: DSS2: VIDEO3 pipeline support Archit Taneja
[not found] ` <CAB2ybb_fDM8bDr1CsFUHRhE9fNoSKvOoWTktQGzh+VV=efEMZw@mail.gmail.com>
2011-08-05 8:43 ` Semwal, Sumit
2011-08-05 9:21 ` Archit Taneja
2011-08-05 9:26 ` Tomi Valkeinen [this message]
2011-08-05 9:46 ` Archit Taneja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1312536396.1907.37.camel@deskari \
--to=tomi.valkeinen@ti.com \
--cc=archit@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=sumit.semwal@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.