All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michel Dänzer" <michel@daenzer.net>
To: Tormod Volden <lists.tormod@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2] drm/radeon: Print gart initialization details on all chipsets
Date: Tue, 30 Aug 2011 09:36:40 +0200	[thread overview]
Message-ID: <1314689800.8151.8.camel@thor.local> (raw)
In-Reply-To: <1314656242-5413-1-git-send-email-lists.tormod@gmail.com>


DRM patches need to be submitted to the dri-devel list, moving there.

On Die, 2011-08-30 at 00:17 +0200, Tormod Volden wrote: 
> From: Tormod Volden <debian.tormod@gmail.com>
> 
> This was previously done for r300 only. Use %p instead of %08X for
> printing the table address.

sizeof(dma_addr_t) can be 8 even when sizeof(void*) is 4.

> Also fix typo in gart warning messages.
> 
> Signed-off-by: Tormod Volden <debian.tormod@gmail.com>

[...]

> diff --git a/drivers/gpu/drm/radeon/radeon_gart.c b/drivers/gpu/drm/radeon/radeon_gart.c
> index a533f52..40f851b 100644
> --- a/drivers/gpu/drm/radeon/radeon_gart.c
> +++ b/drivers/gpu/drm/radeon/radeon_gart.c
> @@ -142,7 +142,7 @@ void radeon_gart_unbind(struct radeon_device *rdev, unsigned offset,
>  	u64 page_base;
>  
>  	if (!rdev->gart.ready) {
> -		WARN(1, "trying to unbind memory to unitialized GART !\n");
> +		WARN(1, "trying to unbind memory to uninitialized GART !\n");

While you're at it, 'unbind from'?


-- 
Earthling Michel Dänzer           |                   http://www.amd.com
Libre software enthusiast         |          Debian, X and DRI developer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

       reply	other threads:[~2011-08-30  7:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1314656242-5413-1-git-send-email-lists.tormod@gmail.com>
2011-08-30  7:36 ` Michel Dänzer [this message]
2011-08-30  9:15   ` [PATCH v2] drm/radeon: Print gart initialization details on all chipsets Tormod Volden
2011-08-30 16:34     ` [PATCH v3] " Tormod Volden
2011-08-31  8:16     ` [PATCH v2] " Michel Dänzer
2011-08-31 10:52       ` Tormod Volden
2011-08-31 10:55         ` Michel Dänzer
2011-08-31 21:54           ` [PATCH v4] " Tormod Volden
2011-09-01  6:52             ` Michel Dänzer
2011-07-05 20:12 [PATCH v2 drm-next] drm: really make debug levels match in edid failure code Tormod Volden
2011-07-05 20:12 ` [PATCH RESEND drm-next] drm/radeon: Print gart initialization details on all chipsets Tormod Volden
2011-07-27 12:24   ` [PATCH v2] " Tormod Volden

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1314689800.8151.8.camel@thor.local \
    --to=michel@daenzer.net \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=lists.tormod@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.