RE: [EXT] Re: [PATCH 1/1] media: amphion: use dev_err_probe

From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: Shijie Qin <shijie.qin@nxp.com>, Eagle Zhou <eagle.zhou@nxp.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Ming Qian <ming.qian@nxp.com>
Cc: "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>
Subject: RE: [EXT] Re: [PATCH 1/1] media: amphion: use dev_err_probe
Date: Wed, 31 May 2023 09:24:04 +0200	[thread overview]
Message-ID: <13280365.uLZWGnKmhe@steina-w> (raw)
In-Reply-To: <AM6PR04MB634181E89FCBAC78DB6F78C1E7BD9@AM6PR04MB6341.eurprd04.prod.outlook.com>

Hi,

Am Freitag, 17. März 2023, 09:52:51 CEST schrieb Ming Qian:
> >Hi,
> >
> >Am Dienstag, 31. Januar 2023, 11:32:44 CET schrieb Alexander Stein:
> >> This simplifies the code and silences -517 error messages. Also the
> >> reason is listed in /sys/kernel/debug/devices_deferred.
> >> 
> >> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> 
> Reviewed-by: ming_qian <ming.qian@nxp.com>

Thanks. Who is going to pick this patch?

Best regards,
Alexander

> >is there any feedback on this?
> >
> >Thanks and best regards,
> >Alexander
> >
> >> ---
> >> 
> >>  drivers/media/platform/amphion/vpu_mbox.c | 9 ++++-----
> >>  1 file changed, 4 insertions(+), 5 deletions(-)
> >> 
> >> diff --git a/drivers/media/platform/amphion/vpu_mbox.c
> >> b/drivers/media/platform/amphion/vpu_mbox.c index
> >> bf759eb2fd46..b6d5b4844f67 100644
> >> --- a/drivers/media/platform/amphion/vpu_mbox.c
> >> +++ b/drivers/media/platform/amphion/vpu_mbox.c
> >> @@ -46,11 +46,10 @@ static int vpu_mbox_request_channel(struct device
> >> *dev, struct vpu_mbox *mbox) cl->rx_callback = vpu_mbox_rx_callback;
> >> 
> >>       ch = mbox_request_channel_byname(cl, mbox->name);
> >> 
> >> -     if (IS_ERR(ch)) {
> >
> >> -             dev_err(dev, "Failed to request mbox chan %s, ret :
> >%ld\n",
> >
> >> -                     mbox->name, PTR_ERR(ch));
> >> -             return PTR_ERR(ch);
> >> -     }
> >> +     if (IS_ERR(ch))
> >> +             return dev_err_probe(dev, PTR_ERR(ch),
> >> +                                  "Failed to request mbox chan
> >
> >%s\n",
> >
> >> +                                  mbox->name);
> >> 
> >>       mbox->ch = ch;
> >>       return 0;
> >
> >--
> >TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
> >Amtsgericht München, HRB 105018
> >Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
> >https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.tq
> >-
> >group.com%2F&data=05%7C01%7Cming.qian%40nxp.com%7Cf727eee294b74
> >d6b250d08db25219119%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%
> >7C638144598318747307%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAw
> >MDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%
> >7C&sdata=UREXcvYNz6K%2FoF%2Bahc7%2Bhos7fv9Lz3N0Fx2u5a%2F8Jlo%3D
> >&reserved=0

-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/