From: Chris Wilson <chris@chris-wilson.co.uk>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH] drm/i915: dump the device info
Date: Wed, 08 Aug 2012 22:41:14 +0100 [thread overview]
Message-ID: <1344462074_60745@CP5-2952> (raw)
In-Reply-To: <1344456111-31467-1-git-send-email-daniel.vetter@ffwll.ch>
On Wed, 8 Aug 2012 22:01:51 +0200, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> Handy for lazy people like me, or when people forget to add the output
> of lspci -nn.
>
> v2: Chris Wilson noticed that we have this duplicated already in the
> i915_capabilites debugfs file. But there \n as separator looks better,
> which would be a bit verbose in dmesg. Abuse the preprocessor to
> extract this all.
>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
I like the placement of the cpp magic next to the struct, that should make
it easier to update both at the same time. I think I'd prefer the struct
first, magic cpp second. And given the alternatives, I think this is
the cleanest way to minimise the code duplication.
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-08-08 21:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-08 16:11 [PATCH] drm/i915: dump the device info Daniel Vetter
2012-08-08 18:29 ` Chris Wilson
2012-08-08 20:01 ` Daniel Vetter
2012-08-08 21:41 ` Chris Wilson [this message]
2012-08-09 16:29 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1344462074_60745@CP5-2952 \
--to=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.