From: richard.zhao@freescale.com (Richard Zhao)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 03/11] USB: chipidea: move OTGSC_IDIS clearing from ci_role_work to irq handler
Date: Tue, 28 Aug 2012 15:03:09 +0800 [thread overview]
Message-ID: <1346137397-32374-4-git-send-email-richard.zhao@freescale.com> (raw)
In-Reply-To: <1346137397-32374-1-git-send-email-richard.zhao@freescale.com>
OTGSC_IDIS must be cleared in irq handler to avoid re-queue the work.
Signed-off-by: Richard Zhao <richard.zhao@freescale.com>
---
drivers/usb/chipidea/core.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
index 3c3ed77..19ef324 100644
--- a/drivers/usb/chipidea/core.c
+++ b/drivers/usb/chipidea/core.c
@@ -273,8 +273,6 @@ static void ci_role_work(struct work_struct *work)
struct ci13xxx *ci = container_of(work, struct ci13xxx, work);
enum ci_role role = ci_otg_role(ci);
- hw_write(ci, OP_OTGSC, OTGSC_IDIS, OTGSC_IDIS);
-
if (role != ci->role) {
dev_dbg(ci->dev, "switching from %s to %s\n",
ci_role(ci)->name, ci->roles[role]->name);
@@ -325,6 +323,7 @@ static irqreturn_t ci_irq(int irq, void *data)
u32 sts = hw_read(ci, OP_OTGSC, ~0);
if (sts & OTGSC_IDIS) {
+ hw_write(ci, OP_OTGSC, OTGSC_IDIS, OTGSC_IDIS);
queue_work(ci->wq, &ci->work);
ret = IRQ_HANDLED;
}
--
1.7.9.5
next prev parent reply other threads:[~2012-08-28 7:03 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-28 7:03 [PATCH v2 00/11] chipidea/imx: add otg support and some bug fix Richard Zhao
2012-08-28 7:03 ` [PATCH v2 01/11] USB: chipidea: imx: add pinctrl support Richard Zhao
2012-08-28 7:03 ` [PATCH v2 02/11] USB: chipidea: delay 2ms before read ID status at probe time Richard Zhao
2012-08-28 7:03 ` Richard Zhao [this message]
2012-08-28 7:03 ` [PATCH v2 04/11] USB: chipidea: clear gadget struct at udc_start fail path Richard Zhao
2012-08-28 8:29 ` Alexander Shishkin
2012-08-28 9:09 ` Richard Zhao
2012-08-29 8:03 ` Alexander Shishkin
2012-08-29 8:22 ` Richard Zhao
2012-08-29 9:44 ` Alexander Shishkin
2012-08-29 10:37 ` Richard Zhao
2012-08-28 7:03 ` [PATCH v2 05/11] USB: chipidea: don't let probe fail if otg controller start one role failed Richard Zhao
2012-08-28 8:38 ` Alexander Shishkin
2012-08-28 9:27 ` Richard Zhao
2012-08-29 8:10 ` Alexander Shishkin
2012-08-29 8:33 ` Richard Zhao
2012-08-29 9:48 ` Alexander Shishkin
2012-08-29 10:46 ` Richard Zhao
2012-09-04 14:17 ` Richard Zhao
2012-09-11 7:23 ` Alexander Shishkin
2012-09-11 8:18 ` Richard Zhao
2012-09-12 10:47 ` Alexander Shishkin
2012-09-14 8:35 ` Richard Zhao
2012-09-14 10:25 ` Alexander Shishkin
2012-09-17 8:59 ` Richard Zhao
2012-08-28 7:03 ` [PATCH v2 06/11] USB: mxs-phy: add basic otg support Richard Zhao
2012-09-11 9:05 ` Felipe Balbi
2012-09-12 10:39 ` Heikki Krogerus
2012-09-14 8:30 ` Richard Zhao
2012-09-14 8:56 ` Chen Peter-B29397
2012-09-14 10:53 ` Richard Zhao
2012-08-28 7:03 ` [PATCH v2 07/11] USB: chipidea: add vbus detect for udc Richard Zhao
2012-08-28 7:03 ` [PATCH v2 08/11] USB: chipidea: convert to use devm_request_irq Richard Zhao
2012-08-28 7:03 ` [PATCH v2 09/11] USB: chipidea: add -DDEBUG if CONFIG_USB_CHIPIDEA_DEBUG Richard Zhao
2012-08-28 7:03 ` [PATCH v2 10/11] USB: chipidea: add set_vbus_power support Richard Zhao
2012-09-19 1:25 ` Richard Zhao
2012-08-28 7:03 ` [PATCH v2 11/11] USB: chipidea: re-order irq handling to avoid unhandled irq Richard Zhao
2012-09-05 14:27 ` [PATCH v2 00/11] chipidea/imx: add otg support and some bug fix Marc Kleine-Budde
2012-09-05 15:01 ` Michael Grzeschik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1346137397-32374-4-git-send-email-richard.zhao@freescale.com \
--to=richard.zhao@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.