All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paulo Zanoni <przanoni@gmail.com>
To: intel-gfx@lists.freedesktop.org
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: [RFC 08/30] drm/i915: don't sleep after selecting the DDI pipe clock
Date: Tue, 28 Aug 2012 19:06:39 -0300	[thread overview]
Message-ID: <1346191621-12996-9-git-send-email-przanoni@gmail.com> (raw)
In-Reply-To: <1346191621-12996-1-git-send-email-przanoni@gmail.com>

From: Paulo Zanoni <paulo.r.zanoni@intel.com>

This is not needed. This sleep is probably here due to the many code
changes that happened to the old intel_ddi_mode_set. We should sleep
20us after turning the PLLs on, and this is already implemented.

Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
---
 drivers/gpu/drm/i915/intel_ddi.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
index 208f13f..33b3a75 100644
--- a/drivers/gpu/drm/i915/intel_ddi.c
+++ b/drivers/gpu/drm/i915/intel_ddi.c
@@ -782,8 +782,6 @@ static void intel_ddi_enable_pipe(struct intel_encoder *intel_encoder,
 
 	I915_WRITE(PIPE_CLK_SEL(pipe), PIPE_CLK_SEL_PORT(port));
 
-	udelay(20);
-
 	func_val = PIPE_DDI_FUNC_ENABLE | PIPE_DDI_SELECT_PORT(port);
 	msa_val = PIPE_MSA_SYNC_CLK;
 
-- 
1.7.11.2

  parent reply	other threads:[~2012-08-28 22:07 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-28 22:06 [RFC 00/30] Haswell clocking+HDMI+DP+eDP fixes Paulo Zanoni
2012-08-28 22:06 ` [RFC 01/30] drm/i915: rewrite the LCPLL code Paulo Zanoni
2012-08-28 22:06 ` [RFC 02/30] drm/i915: disable DDI pipes and ports when initializing Paulo Zanoni
2012-08-28 22:06 ` [RFC 03/30] drm/i915: wait for idle DDI_BUF_CTL after disabling it Paulo Zanoni
2012-08-28 22:06 ` [RFC 04/30] drm/i915: implement DDI disable function Paulo Zanoni
2012-08-28 22:06 ` [RFC 05/30] drm/i915: implement intel_ddi_pll_mode_set Paulo Zanoni
2012-08-28 22:06 ` [RFC 06/30] drm/i915: extract intel_ddi_enable pipe from intel_ddi_mode_set Paulo Zanoni
2012-08-28 22:06 ` [RFC 07/30] drm/i915: make intel_ddi_enable_pipe work on DP Paulo Zanoni
2012-08-28 22:06 ` Paulo Zanoni [this message]
2012-08-28 22:06 ` [RFC 09/30] drm/i915: add DP support to intel_ddi_pll_mode_set Paulo Zanoni
2012-08-28 22:06 ` [RFC 10/30] drm/i915: add DP support to intel_ddi_disable_port Paulo Zanoni
2012-08-28 22:06 ` [RFC 11/30] drm/i915: add DP support to intel_ddi_mode_set Paulo Zanoni
2012-08-28 22:06 ` [RFC 12/30] drm/i915: add basic Haswell DP link train bits Paulo Zanoni
2012-08-28 22:06 ` [RFC 13/30] drm/i915: add intel_ddi_commit Paulo Zanoni
2012-08-28 22:06 ` [RFC 14/30] drm/i915: fix Haswell M/N registers Paulo Zanoni
2012-08-28 22:06 ` [RFC 15/30] drm/i915: fix DP AUX register definitions on Haswell Paulo Zanoni
2012-08-28 22:06 ` [RFC 16/30] drm/i915: disable DDI on intel_dp_link_down Paulo Zanoni
2012-08-28 22:06 ` [RFC 17/30] drm/i915: add intel_ddi_prepare_link_retrain Paulo Zanoni
2012-08-28 22:06 ` [RFC 18/30] drm/i915: add DP support to intel_ddi_disable Paulo Zanoni
2012-08-28 22:06 ` [RFC 19/30] drm/i915: add Haswell DP encoder_helper function definitions Paulo Zanoni
2012-08-28 22:06 ` [RFC 20/30] drm/i915: add TRANSCODER_EDP Paulo Zanoni
2012-08-28 22:06 ` [RFC 21/30] drm/i915: enable eDP on Haswell Paulo Zanoni
2012-08-28 22:06 ` [RFC 22/30] drm/i915: don't run PCH code on non-PCH ports Paulo Zanoni
2012-08-28 22:06 ` [RFC 23/30] drm/i915: init DP on port B Paulo Zanoni
2012-08-28 22:06 ` [RFC 24/30] drm/i915: simplify assignments inside intel_dp.c Paulo Zanoni
2012-08-28 22:06 ` [RFC 25/30] drm/i915: add intel_dp_to_dev and intel_hdmi_to_dev Paulo Zanoni
2012-08-28 22:06 ` [RFC 26/30] drm/i915: create intel_digital_port and use it Paulo Zanoni
2012-08-28 22:06 ` [RFC 27/30] drm/i915: remove encoder args from intel_{dp, hdmi}_add_properties Paulo Zanoni
2012-08-28 22:06 ` [RFC 28/30] drm/i915: split intel_hdmi_init into encoder and connector pieces Paulo Zanoni
2012-08-28 22:07 ` [RFC 29/30] drm/i915: split intel_dp_commit " Paulo Zanoni
2012-08-28 22:07 ` [RFC 30/30] drm/i915: make DDI an encoder Paulo Zanoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1346191621-12996-9-git-send-email-przanoni@gmail.com \
    --to=przanoni@gmail.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=paulo.r.zanoni@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.