From: gregory.clement@free-electrons.com (Gregory CLEMENT)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2] Add support for Aurora L2 Cache Controller
Date: Tue, 4 Sep 2012 12:40:26 +0200 [thread overview]
Message-ID: <1346755232-26006-1-git-send-email-gregory.clement@free-electrons.com> (raw)
Hello,
This a the 2nd version of the patch set (the third if we include the
RFC). See the end of this email for the changelog.
The purpose of this patch set is to add support for Aurora L2 Cache
Controller used by Armada 370 and Armada XP SoCs. As it was initially
designed by Marvell engineer to be compatible with the ARM L2 Cache
Controller, we chose to reuse the existing code and to just extend it
to support the differences and improvements brought by the Aurora
controller.The diffstat looks like:
Documentation/devicetree/bindings/arm/l2cc.txt | 9 +
arch/arm/boot/dts/armada-370.dtsi | 6 +
arch/arm/boot/dts/armada-xp.dtsi | 7 +
arch/arm/include/asm/hardware/cache-aurora-l2.h | 51 ++++
arch/arm/include/asm/hardware/cache-l2x0.h | 1 +
arch/arm/mach-mvebu/Kconfig | 1 +
arch/arm/mach-mvebu/irq-armada-370-xp.c | 4 +
arch/arm/mm/cache-l2x0.c | 298 +++++++++++++++++++++--
8 files changed, 363 insertions(+), 14 deletions(-)
The main differences and improvements are:
- no cache id part number available through hardware (need to get it
by the DT).
- always write through mode available.
- two flavors of the controller 'outer cache' and 'system cache' (the
last one meaning maintenance operations on L1 are broadcasted to the
L2 and L2 performs the same operation).
- in outer cache mode, the cache maintenance operations are improved
and can be done on a range inside a page and are not limited to a
cache line.
- during resume the controller need to restore the ctrl register.
The first patch adds some modifications in the driver
infrastructure. As most of the outer cache functions can use the
Aurora improvements, we had to introduce new functions. So we thought
it was better to use a outer_cache_fns field inside l2x0_of_data and
just memcopy it into outer_cache depending of the type of the l2x0
cache.
Changelog:
V2 -> V1:
- Rebased L2 pach set onto v3.6-rc4.
- Changed the compatible names to be more explicit, from
aurora-cache-with-outer to aurora-outer-cache , and from
aurora-cache-without-outer to aurora-system-cache.
- Add an isb() after the call to mcr in aurora_broadcast_l2_commands().
- Added the tested and reviewed-by from Lior Amsalem and Yehuda
Yitschak.
- Tested on Armada 370 and Armada XP boards and ran benchmark without
seeing any regression.
RFC -> V1:
- Rebased the series on to V3.6-rc3
- Added missing Signed-off-by
- Corrected a compilation warning that I have missed
- Ran benchmarks without seeing any regression
Benchmarks results are visible here:
https://github.com/MISL-EBU-System-SW/mainline-public/wiki/Non-official-cache-bench-results-on-the-mainline-Linux-port-%28-kernels-3.6-rcX%29-of-Armada-XP-and-Armada-370
The git branch aurora-L2-cache-ctrl is visible at
https://github.com/MISL-EBU-System-SW/mainline-public.git
Regards,
Gregory
next reply other threads:[~2012-09-04 10:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-04 10:40 Gregory CLEMENT [this message]
2012-09-04 10:40 ` [PATCH V2 1/6] arm: cache-l2x0: make outer_cache_fns a field of l2x0_of_data Gregory CLEMENT
2012-09-04 10:40 ` [PATCH V2 2/6] arm: cache-l2x0: add an optional register to save/restore Gregory CLEMENT
2012-09-04 10:40 ` [PATCH V2 3/6] arm: cache-l2x0: add support for Aurora L2 cache ctrl Gregory CLEMENT
2012-09-04 11:22 ` Will Deacon
2012-09-04 14:50 ` Gregory CLEMENT
2012-09-04 17:26 ` Will Deacon
2012-09-05 9:23 ` Gregory CLEMENT
2012-09-04 10:40 ` [PATCH V2 4/6] arm: mvebu: add L2 cache support Gregory CLEMENT
2012-09-04 10:40 ` [PATCH V2 5/6] arm: mvebu: add Aurora L2 Cache Controller to the DT Gregory CLEMENT
2012-09-04 10:40 ` [PATCH V2 6/6] arm: l2x0: add aurora related properties to OF binding Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1346755232-26006-1-git-send-email-gregory.clement@free-electrons.com \
--to=gregory.clement@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.