From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: LKML <linux-kernel@vger.kernel.org>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
DRI Development <dri-devel@lists.freedesktop.org>,
Dave Airlie <airlied@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH 2/2] [RESEND] console: implement lockdep support for console_lock
Date: Mon, 24 Sep 2012 14:17:07 +0200 [thread overview]
Message-ID: <1348489027.11847.53.camel@twins> (raw)
In-Reply-To: <1347923013-4253-2-git-send-email-daniel.vetter@ffwll.ch>
On Tue, 2012-09-18 at 01:03 +0200, Daniel Vetter wrote:
> - In the printk code there's a special trylock, only used to kick off
> the logbuffer printk'ing in console_unlock. But all that happens
> while lockdep is disable (since printk does a few other evil
> tricks). So no issue there, either.
Not particularly evil, just plain broken.
See this series:
http://marc.info/?l=linux-kernel&m=132446644123326&w=2
In particular see patches 1-4. The problem with lockdep is that lockdep
uses printk and printk's recursion stuff is utterly broken.
Console drivers being on crack simply doesn't help :-) Note that I would
never recommend drm/ksm to anybody who really cares about their console
output.
next prev parent reply other threads:[~2012-09-24 12:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-17 23:03 [PATCH 1/2] [RESEND] console: use might_sleep in console_lock Daniel Vetter
2012-09-17 23:03 ` [PATCH 2/2] [RESEND] console: implement lockdep support for console_lock Daniel Vetter
2012-09-18 7:33 ` Jani Nikula
2012-09-18 7:33 ` Jani Nikula
2012-09-19 7:30 ` Daniel Vetter
2012-09-22 17:52 ` [PATCH] " Daniel Vetter
2012-09-22 20:06 ` [Intel-gfx] " Greg KH
2012-09-22 20:06 ` Greg KH
2012-09-24 11:36 ` [Intel-gfx] " Daniel Vetter
2012-10-02 12:56 ` Daniel Vetter
2012-10-02 13:28 ` Greg KH
2012-10-02 13:28 ` Greg KH
2012-10-02 13:31 ` [Intel-gfx] " Daniel Vetter
2012-09-24 12:17 ` Peter Zijlstra [this message]
2012-09-24 12:24 ` [PATCH 2/2] [RESEND] " Peter Zijlstra
2012-09-24 12:54 ` Daniel Vetter
2012-09-24 13:10 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1348489027.11847.53.camel@twins \
--to=a.p.zijlstra@chello.nl \
--cc=airlied@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.